Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version parsing to better support "preambles" #2394

Closed
JohnMcPMS opened this issue Jul 29, 2022 · 5 comments
Closed

Improve version parsing to better support "preambles" #2394

JohnMcPMS opened this issue Jul 29, 2022 · 5 comments
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone

Comments

@JohnMcPMS
Copy link
Member

Description of the new feature / enhancement

The version parsing could be improved to ignore leading, non-numeric values that are then followed by a more normal version number. This would apply to versions like v1.2.3, as well as the package detailed in microsoft/winget-pkgs#67794

For example ad 7.0.13 would equal 7.0.13 and v1.2.3 would equal 1.2.3.
foo1 would equal bar1, but 1.foo2 would not equal 1.bar2, as only leading non-numeric characters would be ignored.

Proposed technical implementation details

For the first version part (where parts are split by the . character), determine if there is a number at the end (currently only decimal integers are supported) and use it as the integer portion. Do not use the "preamble" in the version at all.

@JohnMcPMS JohnMcPMS added the Issue-Feature This is a feature request for the Windows Package Manager client. label Jul 29, 2022
@ghost ghost added the Needs-Triage Issue need to be triaged label Jul 29, 2022
@JohnMcPMS JohnMcPMS removed the Needs-Triage Issue need to be triaged label Jul 29, 2022
@Trenly
Copy link
Contributor

Trenly commented Jul 29, 2022

Related to #1298

@luzpaz
Copy link

luzpaz commented Dec 4, 2023

What's the tipping point for this issue to be solved ?

@Pandoriaantje
Copy link

What's the tipping point for this issue to be solved ?

There seems to be no mechanism to handle beta/release candidate, etc. version numbering, which leaves the users at the hands of however winget interprets the version number. This could lead to false 'upgrades'.

@denelon
Copy link
Contributor

denelon commented Jan 5, 2024

That's correct, we still have a big chunk of work left in order to handle channels.

@Trenly
Copy link
Contributor

Trenly commented Jun 26, 2024

Resolved by #4558

@denelon denelon added this to the 1.8 Client milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

5 participants