Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: Jackaudio.JACK2 has superflous 'v' prepending version number and should be renamed #129013

Open
2 tasks done
luzpaz opened this issue Dec 3, 2023 · 3 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Package-Update This package needs to be updated

Comments

@luzpaz
Copy link

luzpaz commented Dec 3, 2023

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

Per repology jack2 is showing a superfluous 'v' before the version name
Screenshot_20231203_062820

This is how the package is listed in winget-pkgs
Screenshot_20231203_062155

Note: this seems like an anomaly in winget-pkgs. Usually version numbers don't have a 'v' prepended.

This has been reported to repology

Screenshot_20231203_062552

Per repology's answer, this needs to be corrected in this repo

Steps to reproduce

See above

Actual behavior

See above

Expected behavior

See above

Environment

n/a

Screenshots and Logs

See above

@luzpaz luzpaz added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Dec 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Dec 3, 2023
@Trenly
Copy link
Contributor

Trenly commented Dec 3, 2023

When the package is installed, it writes v1.9.22 to the control panel, so the v is not superflous and is, in fact, required for matching the available version to the installed version.

--> Installing the Manifest v1.9.22

Found JACK2 [Jackaudio.JACK2] Version v1.9.22
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/jackaudio/jack2-releases/releases/download/v1.9.22/jack2-win64-v1.9.22.exe
  ██████████████████████████████  19.2 MB / 19.2 MB
Successfully verified installer hash
Starting package install...
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName           DisplayVersion Publisher     ProductCode Scope
-----------           -------------- ---------     ----------- -----
JACK2 version v1.9.22 v1.9.22        jackaudio.org JACK2_is1   Machine

@luzpaz
Copy link
Author

luzpaz commented Dec 4, 2023

Not disputing that. It's just that, per repology, winget is the anomaly in comparison to the the rest of the packaging ecosystem. No other downstream packager prepends the 'v'.

@stephengillie
Copy link
Collaborator

@stephengillie stephengillie added Package-Update This package needs to be updated and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Package-Update This package needs to be updated
Projects
None yet
Development

No branches or pull requests

3 participants