chore: Bump tracing-subscriber from 0.3.19 to 0.3.20#492
Conversation
|
@dependabot rebase |
Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.19 to 0.3.20. - [Release notes](https://github.com/tokio-rs/tracing/releases) - [Commits](tokio-rs/tracing@tracing-subscriber-0.3.19...tracing-subscriber-0.3.20) --- updated-dependencies: - dependency-name: tracing-subscriber dependency-version: 0.3.20 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
e86163e to
a596874
Compare
779dd45 to
7dbb48f
Compare
to fix failures in binding generation. We use case-inensistive regex patterns while calling allowlist_file() at some places. This does not work without the unicode-case feature. In the past it used to be enabled by tracing-subscriber which served our allowlist-file() use-case as well by accident. But the new version of tracing-subscriber has removed the dependency on the regex crate thereboy breaking our bindgen code. In this fix we have added an explicit depenency on regex ourselves with said feature enabled.
7dbb48f to
4541d6c
Compare
There was a problem hiding this comment.
This PR also seems to introduce 2 different versions of windows-sys into the build. This is not ideal for build times etc, but we can push that fix to a followup to unblock pipelines rn. It should just involving determining what's bringing in the duplicate versions and trying to uses cargo update to target an update to one. It might involve submitting a pr to loosen windows-sys version in a dependency, but i doubt that would be needed in this case since there are no new deps introduced in this pr.
Not sure why clippy isn't catching the duplicate though since we should already have https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions enabled
tracking this in #500 |
Looking at the Cargo.lock file, It seems (the new windows-sys 0.52.0 version) to have come from |
yup. That's captured in #500 |
Bumps tracing-subscriber from 0.3.19 to 0.3.20. Also explicitly includes
regexinwdk-buildto enable case-insensitive regex viaunicode-casefeature. related to rust-lang/rust-bindgen#3289Release notes
Sourced from tracing-subscriber's releases.
Commits
4c52ca5fmt: fix ANSI escape sequence injection vulnerability (#3368)f71cebesubscriber: impl Clone for EnvFilter (#3360)3a1f571Fix CI (#3361)e63ef57chore: prepare tracing-attributes 0.1.30 (#3316)6e59a13attributes: fix tracing::instrument regression around shadowing (#3311)e4df761tracing: update core to 0.1.34 and attributes to 0.1.29 (#3305)643f392chore: prepare tracing-attributes 0.1.29 (#3304)d08e7a6chore: prepare tracing-core 0.1.34 (#3302)6e70c57tracing-subscriber: count numbers of enters inTimings(#2944)c01d4fdfix docs and enable CI onmainbranch (#3295)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.