Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hangdump running into crashdump #4378

Merged
merged 12 commits into from
Apr 24, 2023
Merged

Fix hangdump running into crashdump #4378

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
84c52d9
Fix hangdump running into crashdump
nohwnd Apr 6, 2023
dcdcc46
Figure out crash dump
nohwnd Apr 11, 2023
7f897ad
Better logs
nohwnd Apr 11, 2023
442ba93
Review feedback
nohwnd Apr 11, 2023
b7e5125
Update src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Blame…
Evangelink Apr 12, 2023
6a518bd
Fix
nohwnd Apr 20, 2023
55a14ce
Merge branch 'main' into fix-hangdump-running-into-crashdump
nohwnd Apr 20, 2023
78d856b
Fix
nohwnd Apr 20, 2023
fd6599c
Merge branch 'fix-hangdump-running-into-crashdump' of https://github.…
nohwnd Apr 20, 2023
e123d0d
Revert
nohwnd Apr 20, 2023
076c336
Fix test
nohwnd Apr 20, 2023
a76cb1a
Fix tests
nohwnd Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Blame… 
…Collector.cs

Co-authored-by: Jakub Jareš <me@jakubjares.com>
  • Loading branch information
@Evangelink @nohwnd
Evangelink and nohwnd authored Apr 12, 2023
commit b7e5125029ea667d8d87c3ee33b397ac4ff79984
2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.Extensions.BlameDataCollector/BlameCollector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ private void CollectDumpAndAbortTesthost()

if (_collectProcessDumpOnCrash)
{
// Detach the dumper from the testhost process to prevent testhost process. When the dumper is procdump.exe
// Detach the dumper from the testhost process to prevent crashing testhost process. When the dumper is procdump.exe
// it must be detached before we try to dump the process, and simply killing it would take down the testhost process.
//
// Detaching also prevents creating an extra dump at the exit of the testhost process.
Expand Down