Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hangdump running into crashdump #4378

Merged
merged 12 commits into from
Apr 24, 2023
Merged

Fix hangdump running into crashdump #4378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
84c52d9
Fix hangdump running into crashdump
nohwnd Apr 6, 2023
dcdcc46
Figure out crash dump
nohwnd Apr 11, 2023
7f897ad
Better logs
nohwnd Apr 11, 2023
442ba93
Review feedback
nohwnd Apr 11, 2023
b7e5125
Update src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Blame…
Evangelink Apr 12, 2023
6a518bd
Fix
nohwnd Apr 20, 2023
55a14ce
Merge branch 'main' into fix-hangdump-running-into-crashdump
nohwnd Apr 20, 2023
78d856b
Fix
nohwnd Apr 20, 2023
fd6599c
Merge branch 'fix-hangdump-running-into-crashdump' of https://github.…
nohwnd Apr 20, 2023
e123d0d
Revert
nohwnd Apr 20, 2023
076c336
Fix test
nohwnd Apr 20, 2023
a76cb1a
Fix tests
nohwnd Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
@nohwnd
nohwnd committed Apr 20, 2023
commit 78d856b30da58c3a4c147d7c3a8752e74bfa38e2
2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.Build/Resources/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/Microsoft.TestPlatform.Acceptance.IntegrationTests/BlameDataCollectorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public void CrashDumpOnStackOverflow(RunnerInfo runnerInfo)
var assemblyPaths = GetAssetFullPath("crash.dll");
var arguments = PrepareArguments(assemblyPaths, GetTestAdapterPath(), string.Empty, string.Empty, runnerInfo.InIsolationValue);
arguments = string.Concat(arguments, $" /ResultsDirectory:{TempDirectory.Path}");
arguments = string.Concat(arguments, $@" /Blame:""CollectHangDump;TestTimeout=10s;CollectDump;DumpType=full"" /diag:S:\t\logs\l1\");
arguments = string.Concat(arguments, $@" /Blame:""CollectHangDump;TestTimeout=15s;CollectDump;DumpType=full"" /diag:S:\t\logs\l1\");

var env = new Dictionary<string, string?>
{
Expand Down
3 changes: 1 addition & 2 deletions ...Microsoft.TestPlatform.Extensions.BlameDataCollector.UnitTests/ProcessDumpUtilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System;
using System.IO;

using Microsoft.VisualStudio.TestPlatform.PlatformAbstractions.Interfaces;
Expand Down Expand Up @@ -63,7 +62,7 @@ public void GetDumpFileWillThrowExceptionIfNoDumpfile()

processDumpUtility.StartTriggerBasedProcessDump(processId, testResultsDirectory, false, ".NETCoreApp,Version=v5.0", false, _ => { });

var ex = Assert.ThrowsException<FileNotFoundException>(() => processDumpUtility.GetDumpFiles(true, false, DateTime.Now));
var ex = Assert.ThrowsException<FileNotFoundException>(() => processDumpUtility.GetDumpFiles(true, false));
Assert.AreEqual(ex.Message, Resources.Resources.DumpFileNotGeneratedErrorMessage);
}
}