Upgrade to Newtonsoft.Json 13.0.1 #3815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haplois
approved these changes
Jun 29, 2022
Evangelink
reviewed
Jun 29, 2022
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
I cannot see coverage but I am unsure all the new ifs added are covered.
samples/Microsoft.TestPlatform.Protocol/Microsoft.TestPlatform.Protocol.csproj
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/Serialization/TestObjectConverter.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/Serialization/TestObjectConverter.cs
Outdated
Show resolved
Hide resolved
...tPlatform.CrossPlatEngine/AttachmentsProcessing/DataCollectorAttachmentProcessorAppDomain.cs
Outdated
Show resolved
Hide resolved
Haplois
reviewed
Jun 29, 2022
scripts/build.sh
Outdated
| #*************************************************************************************************************# | ||
|
|
||
| newtonsoft=$TP_PACKAGES_DIR/newtonsoft.json/9.0.1/lib/netstandard1.0/Newtonsoft.Json.dll | ||
| newtonsoft=$TP_PACKAGES_DIR/newtonsoft.json/13.0.1/lib/netstandard1.0/Newtonsoft.Json.dll |
Contributor
There was a problem hiding this comment.
Since we're reading the version from Versions.props in build.ps1, can we do it here as well? This file has samples.
Member
There was a problem hiding this comment.
You said done but I still see the version used here.
MarcoRossignoli
approved these changes
Jun 29, 2022
Evangelink
reviewed
Jun 29, 2022
scripts/build.sh
Outdated
| #*************************************************************************************************************# | ||
|
|
||
| newtonsoft=$TP_PACKAGES_DIR/newtonsoft.json/9.0.1/lib/netstandard1.0/Newtonsoft.Json.dll | ||
| newtonsoft=$TP_PACKAGES_DIR/newtonsoft.json/13.0.1/lib/netstandard1.0/Newtonsoft.Json.dll |
Member
There was a problem hiding this comment.
You said done but I still see the version used here.
src/Microsoft.TestPlatform.CommunicationUtilities/Serialization/TestObjectConverter.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 29, 2022
Evangelink
approved these changes
Jun 30, 2022
This was referenced Jul 21, 2022
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Feb 10, 2023
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Feb 16, 2023
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Feb 16, 2023
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
* Upgrade to Newtonsoft.Json 13.0.1 (#3815) * Update versions * Move version to 17.3.3
nohwnd
added a commit
that referenced
this pull request
Feb 22, 2023
* Fix build * Upgrade to Newtonsoft.Json 13.0.1 (#3815) * Upgrade arcade * update vs image used to build * Add 3.1.32 dotnet runtime * Ignore acceptance test for multi targetting, we did not touch that, it relies on an edge case, and it does not depend on newtonsoft * Bump version * Fix version
nohwnd
added a commit
that referenced
this pull request
Feb 22, 2023
* Upgrade to Newtonsoft.Json 13.0.1 (#3815) * upgrade arcade * Fix * downgrade ubuntu * Dowgrade ubuntu more * Bump version * Fix version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Newtonsoft.Json 13.0.1.