Revert "Merge pull request #282291 from microsoft/anthonykim1/update-…#282516
Merged
Revert "Merge pull request #282291 from microsoft/anthonykim1/update-…#282516
Conversation
anthonykim1
approved these changes
Dec 10, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous update that upgraded node-pty from version 1.1.0-beta35 to 1.1.0-beta39. The revert restores the older beta35 version across all dependency manifests and updates the associated conpty.dll version reference in the terminal configuration.
Key changes:
- Downgrade node-pty from
^1.1.0-beta39to1.1.0-beta35in all package manifests - Revert conpty.dll version reference from
v1.23.251008001tov1.22.250204002 - Update package lock files with correct integrity hashes for the downgraded version
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Downgrade node-pty dependency from beta39 to beta35 (removed version range prefix) |
| remote/package.json | Downgrade node-pty dependency from beta39 to beta35 in remote package |
| package-lock.json | Update node-pty resolved version and integrity hash for beta35 |
| remote/package-lock.json | Update node-pty resolved version and integrity hash for beta35 in remote lock |
| src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts | Revert conpty.dll version reference in terminal configuration description |
Files not reviewed (1)
- remote/package-lock.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…node-pty-39"
This reverts commit 4f4ddd8, reversing changes made to 55ca409.
This broke the product build.
cc @anthonykim1