Skip to content

Update node-pty to 1.1.0-beta39#282291

Merged
Tyriar merged 1 commit intomainfrom
anthonykim1/update-node-pty-39
Dec 10, 2025
Merged

Update node-pty to 1.1.0-beta39#282291
Tyriar merged 1 commit intomainfrom
anthonykim1/update-node-pty-39

Conversation

@anthonykim1
Copy link
Contributor

@anthonykim1 anthonykim1 commented Dec 9, 2025

Take2 on: #274736

Part of #269213

Maybe we hold off to this until issue grooming gets wrapped up

@anthonykim1 anthonykim1 self-assigned this Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 20:06
@anthonykim1 anthonykim1 added this to the December / January 2026 milestone Dec 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the node-pty dependency from version 1.1.0-beta35 to 1.1.0-beta39, which includes updates to the bundled conpty implementation and adds Buffer support to the API. The update affects both the main package and the remote package dependencies, with corresponding package-lock.json updates. Additionally, the conpty.dll version reference in the terminal configuration description is updated to reflect the new bundled version.

Key changes:

  • Updates node-pty dependency from 1.1.0-beta35 to ^1.1.0-beta39 (adds caret for semver flexibility)
  • Updates conpty.dll version reference from v1.22.250204002 to v1.23.251008001 in configuration description
  • Updates package-lock.json files with new integrity hashes for the updated dependency

Note: While the PR description mentions that Buffer support has been added to the API (microsoft/node-pty#812), there is existing code in src/vs/platform/terminal/node/terminalProcess.ts (lines 546-548) with a TODO comment referencing this exact PR and a workaround using as any cast that should be addressed in a follow-up change. This file is not included in the current PR but represents technical debt that can now be cleaned up.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updates node-pty dependency to ^1.1.0-beta39 with caret for semver range
package-lock.json Updates resolved URL and integrity hash for node-pty@1.1.0-beta39
remote/package.json Updates node-pty dependency to ^1.1.0-beta39 for remote scenarios
remote/package-lock.json Updates resolved URL and integrity hash for node-pty@1.1.0-beta39 in remote package
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts Updates conpty.dll version string in user-facing configuration description from v1.22.250204002 to v1.23.251008001
Files not reviewed (1)
  • remote/package-lock.json: Language not supported

@anthonykim1
Copy link
Contributor Author

anthonykim1 commented Dec 9, 2025

Still seem to run fine when tested locally with oss.
Testing locally on OSS should be enough, right? @Tyriar

},
[TerminalSettingId.WindowsUseConptyDll]: {
markdownDescription: localize('terminal.integrated.windowsUseConptyDll', "Whether to use the experimental conpty.dll (v1.22.250204002) shipped with VS Code, instead of the one bundled with Windows."),
markdownDescription: localize('terminal.integrated.windowsUseConptyDll', "Whether to use the experimental conpty.dll (v1.23.251008001) shipped with VS Code, instead of the one bundled with Windows."),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated the conpty dll version defined in the setting to reflect update from node-pty

@anthonykim1 anthonykim1 requested a review from Tyriar December 9, 2025 20:47
@anthonykim1 anthonykim1 marked this pull request as ready for review December 9, 2025 20:48
@Tyriar
Copy link
Member

Tyriar commented Dec 10, 2025

Seems to be working now 🤷 not sure what was happening before.

@Tyriar Tyriar merged commit 4f4ddd8 into main Dec 10, 2025
33 of 34 checks passed
@Tyriar Tyriar deleted the anthonykim1/update-node-pty-39 branch December 10, 2025 14:35
Tyriar added a commit that referenced this pull request Dec 10, 2025
…node-pty-39"

This reverts commit 4f4ddd8, reversing
changes made to 55ca409.
Tyriar added a commit that referenced this pull request Dec 10, 2025
Revert "Merge pull request #282291 from microsoft/anthonykim1/update-…
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants