Fix terminal creation in auxiliary windows when using Ctrl+Shift+`#259001
Merged
Fix terminal creation in auxiliary windows when using Ctrl+Shift+`#259001
Conversation
…indow context Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Running the create new terminal command when inside a new window should create the terminal in that window
Fix terminal creation in auxiliary windows when using Ctrl+Shift+`
Jul 31, 2025
Tyriar
approved these changes
Aug 3, 2025
Tyriar
approved these changes
Aug 3, 2025
dbaeumer
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a terminal is moved into a new window using "Move Terminal into New Window" and then the "Create New Terminal" command (Ctrl+Shift+`) is executed from that auxiliary window, the terminal was incorrectly being created in the original main window instead of the current auxiliary window.
Problem
The issue occurred because the
TerminalCommandId.Newaction did not consider which window context it was running in. It would always fall back to the terminal service'sdefaultLocation(Panel or Editor based on configuration), which targets the main window.Solution
Modified the terminal creation logic in
terminalActions.tsto:IsAuxiliaryWindowContextcontext keyeditorGroupToColumn(editorGroupsService, editorGroupsService.activeGroup)Changes
IContextKeyServiceandIsAuxiliaryWindowContextTerminalCommandId.Newaction handlerThe fix is minimal and conservative - it only changes behavior for auxiliary windows and only when no explicit location is specified, ensuring no regressions in existing functionality.
Fixes #259000.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.orgnode-gyp(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.