shellIntegration-bash.sh: escape values in "E" (executed command) and "P" (property KV) codes #165632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwe
force-pushed
the
serialize-message-bash
branch
from
3422813 to
b5d18e6
Compare
This was referenced Nov 6, 2022
shellIntegration-rc.zsh: escape values in "E" (executed command) and "P" (property KV) codes
#165633
Merged
Merged
rwe
force-pushed
the
serialize-message-bash
branch
from
b5d18e6 to
ca36ef8
Compare
rwe
force-pushed
the
serialize-message-bash
branch
from
ca36ef8 to
00bc33e
Compare
rwe
force-pushed
the
serialize-message-bash
branch
from
00bc33e to
b05120f
Compare
joyceerhl
approved these changes
Nov 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the string escaping scheme documented for the "E" (executed) and "P" (property KV) codes. This is "pure"
bashand relies on no external utilities.Although currently the only "required" escapes are backslash, semicolon,
\a, and perhaps newlines, this conservatively escapes all non-alphanumeric characters.Backslashes are doubled, non-alphanumerics are hex-escaped.
Sibling to:
deserializeMessage()implementation + add tests #165635Relates to or resolves parts of: