shellIntegration.fish: escape values in "E" (executed command) and "P" (property KV) codes #165631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwe
force-pushed
the
serialize-message-fish
branch
from
1c9e068 to
e0ccd7f
Compare
rwe
force-pushed
the
serialize-message-fish
branch
from
e0ccd7f to
a9776c3
Compare
rwe
force-pushed
the
serialize-message-fish
branch
2 times, most recently
from
cd03161 to
579be93
Compare
Note that '\x3b' ⇔ '\\x3b', since fish does not recognize '\x' as a known escape: however since a literal backslash is intended, it's clearer to write it explicitly.
rwe
force-pushed
the
serialize-message-fish
branch
from
579be93 to
50d59d7
Compare
connor4312
approved these changes
Nov 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the string escaping scheme documented for the "E" (executed) and "P" (property KV) codes. This is "pure" fish and relies on no external utilities.
Although currently the only "required" escapes are backslash, semicolon, \x07, and perhaps newlines, this conservatively escapes all non-alphanumeric characters.
Backslashes are doubled, non-alphanumerics are hex-escaped.
Sibling to:
deserializeMessage()implementation + add tests #165635Relates to:
and others.