Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joh/innocent tiger #155321

Merged
merged 6 commits into from
Jul 15, 2022
Merged

joh/innocent tiger #155321

merged 6 commits into from
Jul 15, 2022

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Jul 15, 2022 •
edited
Loading

This is the first cut for #145929, a bunch of debt/refactoring works, and small tweaks to surround-with

  • surround with code action needs non-empty selection, uses active end of selection
  • no hidden snippets as code action
  • add concept of top level snippet and allow to get snippets without language filter
  • make snippet-contribution a proper contrib-file, remove local registration into contrib-file, move command into their own folder, have a command to populate a file from a top-level snippet
  • tweak label
  • add "start with snippet" to empty editor text, change things to use formatted text renderer (fixes Wrong use of nls-utils in untitledTextEditorHint.ts #155293)

@jrieken jrieken self-assigned this Jul 15, 2022
@jrieken jrieken mentioned this pull request Jul 15, 2022
Closed
@VSCodeTriageBot VSCodeTriageBot added this to the July 2022 milestone Jul 15, 2022
connor4312
connor4312 approved these changes Jul 15, 2022
View reviewed changes
src/vs/workbench/contrib/codeEditor/browser/untitledTextEditorHint.ts

// ugly way to associate keybindings...
const keybindingsLookup = [ChangeLanguageAction.ID, SelectSnippetForEmptyFile.Id, 'welcome.showNewFileEntries'];
for (const anchor of hintElement.querySelectorAll('A')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getElementsByTagName is slightly faster

@jrieken jrieken merged commit 5315bc8 into main Jul 15, 2022
@jrieken jrieken deleted the joh/innocent-tiger branch July 15, 2022 18:48
jrieken added a commit that referenced this pull request Jul 18, 2022
@jrieken
Merge pull request #155321 from microsoft/joh/innocent-tiger
ebdd965 
joh/innocent tiger
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connor4312 connor4312 connor4312 approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

Wrong use of nls-utils in untitledTextEditorHint.ts
3 participants
@jrieken @connor4312 @VSCodeTriageBot