Skip to content

Wrong use of nls-utils in untitledTextEditorHint.ts #155293

Closed

Description

  • src/vs/workbench/contrib/codeEditor/browser/untitledTextEditorHint.ts
  • there is string concatenation of nls-strings, like this and much more
  • This is usually wrong because it assumes that all languages use similar sequences. The localize-function support replacements for cases like this and in this specific case we might be better off using a markdown string with command-links

/cc @isidorn who original did this: please speak up if there is more code like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

insiders-releasedPatch has been released in VS Code Insiders

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions