Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline chat: Black bar on top of editor-only result #208418

Closed
Tyriar opened this issue Mar 22, 2024 · 8 comments · Fixed by #208883
Closed

Inline chat: Black bar on top of editor-only result #208418

Tyriar opened this issue Mar 22, 2024 · 8 comments · Fixed by #208883
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug inline-chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2024

Repro:

  1. Ask in inline chat: /fix import flask could not be resolved

image

@Tyriar
Copy link
Member Author

Tyriar commented Mar 22, 2024

Oh it's a scroll shadow:

image

@jrieken jrieken added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Mar 22, 2024
@VSCodeTriageBot
Copy link
Collaborator

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@jrieken
Copy link
Member

jrieken commented Mar 22, 2024

I blame it your theme. Inline chat isn't doing anything special here, tho we might wanna tweak the min size

@Tyriar
Copy link
Member Author

Tyriar commented Mar 22, 2024

The problem here is that the height of the chat widget inside the inline chat isn't correct and doesn't seem to be updated when the answer is streamed in. There is much more than 40% room available so it should show the full response. Also this is Dark Modern; the theme is fine it's the size:

Recording 2024-03-22 at 08 12 44

@Tyriar Tyriar reopened this Mar 22, 2024
@jrieken
Copy link
Member

jrieken commented Mar 22, 2024

inside the inline chat isn't correct and doesn't seem to be updated when the answer is streamed in

That's surprising. Notice how it works here until it reaches the max zone height

Screen.Recording.2024-03-22.at.16.31.10.mov

@jrieken jrieken added inline-chat and removed *question Issue represents a question, should be posted to StackOverflow (VS Code) labels Mar 22, 2024
@jrieken jrieken added this to the March 2024 milestone Mar 22, 2024
@jrieken
Copy link
Member

jrieken commented Mar 22, 2024

Must be related to the code block being replied with. But whatever I do I cannot get it to reply like that...

@jrieken
Copy link
Member

jrieken commented Mar 22, 2024

Ok, I can repro in a TS file with import * as ts from 'react'. Looks like the tree reports the wrong content height. Overall we measure 94px (for the input and tree) when in fact only the tree is 107px

Screenshot 2024-03-22 at 16 37 16

@jrieken
Copy link
Member

jrieken commented Mar 22, 2024

@roblourens Is editor rendering somehow async and should I ask for content height at some later point?

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Mar 22, 2024
jrieken added a commit that referenced this issue Mar 27, 2024
jrieken added a commit that referenced this issue Mar 27, 2024
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 27, 2024
@meganrogge meganrogge added the verified Verification succeeded label Mar 27, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug inline-chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
4 participants