Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Chat Widget: Remove Request and Response leaves a lot of "padding" #208570

Closed
benibenj opened this issue Mar 25, 2024 · 3 comments
Closed

Inline Chat Widget: Remove Request and Response leaves a lot of "padding" #208570

benibenj opened this issue Mar 25, 2024 · 3 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug inline-chat verified Verification succeeded
Milestone
March 2024

Comments

@benibenj
Copy link
Contributor

Testing #208414

When removing a request and response, there is a lot of empty space left afterwards.

Code_-_Insiders_99p4Qo8GVS
@jrieken jrieken added this to the March 2024 milestone Mar 25, 2024
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug inline-chat labels Mar 25, 2024
@jrieken
Copy link
Member

jrieken commented Mar 25, 2024

Seems to be missing a layout but I also wonder if this should be supported here

@jrieken
Copy link
Member

jrieken commented Mar 27, 2024

The UI glitch will be fixed with #208418 but the model isn't updated yet

@jrieken
Copy link
Member

jrieken commented Mar 27, 2024

Closing this because the UI is now proper, the model-updating is part of #208898 and that's a way bigger story

@jrieken jrieken closed this as completed Mar 27, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 27, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug inline-chat verified Verification succeeded
Projects
None yet
Milestone
March 2024
Development

No branches or pull requests
4 participants
@jrieken @rzhao271 @benibenj and others