Support audio controls in Notebook Renderer

[DonJayamanne]

Request: Add support for Audio Control in Notebook Renderer.

• Originally posted here VSCode >= 1.13 greys out audio controls in previewHTML? #32540
• Custom implementation for Notebook Renderers Add support for WAV playback inside notebook cell vscode-notebook-renderers#33

We (Jupyter Extension) can accept the PR, however this would mean the Jupyter extension now has a custom renderer for HTML.
And I'm not too keen on owning rendering all HTML content in Notebook renderers (I know VS Code has custom code to handle a lot of the HTML content, links, etc).

Suggestion

• Please can we re-visit this issue
• Is it possible to provide some way for the Notebook to override the preferred renderer based on the content?
  • I.e. I'd prefer to always use the built in renderer for HTML
  • However if VS Code will not support wav natively, then we can override the preferred renderer and use the one we ship.

@rebornix /cc

[mcmar]

This entire issue could be obviated if you just ship a build with ffmpeg. That's probably the preferable solution to all this.
See:
#32540
#54097
#66050

[robinhad]

I think a good solution will be to build VSCode with some kind of "libre" ffmpeg - with only wav, ogg, vorbis for audio and AV1 for video.
It will facilitate the most common use cases for audio/video processing and will not bloat VSCode too much.

[rebornix]

Assigning to @deepak1556 and @mjbvz as this is more about audio control in webview.

[mcmar]

I just want to point out that the whole reason we're here today is because ffmpeg inclusion was previously stonewalled multiple times and we were told to create an HTML workaround.
So here we are with a workaround for WAV audio because a codec technically isn't required for WAV audio. Now people are complaining that the workaround is complex. That's fair, but I just don't want to get stuck in-between two solutions where we end up doing nothing. I hope we can all commit to picking between either the HTML-based WAV audio workaround or adding ffmpeg to the build. It's really not fair to users to stonewall this issue forever.

[DonJayamanne]

Now people are complaining that the workaround is complex.

I apologise for making it sound if the solution implemented by @robinhad is complex. That was not my intention at all.

[mcmar]

@DonJayamanne Sorry, I should rephrase that. Just want to make sure that we do something here.
Options so far:

1. ffmpeg
2. slim compiled ffmpeg (see here)
3. HTML-based workaround

[rchiodo]

In case anybody is looking for the reason why this is important for jupyter customers, here's our original issue:
microsoft/vscode-jupyter#1012