-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WAV playback inside notebook cell #33
Conversation
Thanks a lot @robinhad The one concern I have with this is the fact that we will now always render HTML & not VS Code. Once again, thanks for this PR. |
Starred a conversation here microsoft/vscode#118275 |
Thank you for your reply, @DonJayamanne ! |
Hi thanks for this PR. Can someone review and merge this PR, please? |
@robinhad Can you please provide guide how can I use this patch like in beta mode in my workaround. |
I don't think we're going to take this PR. We'd rather not have an html viewer in the jupyter extension. VS code should address the underlying problem instead as in this issue: |
@robinhad if you wanted to ship this, you could make your own renderer extension for the 'text/html' mimetype. |
This pull request adds support for WAV playback inside notebook cell.
Screen.recording.2021-03-04.12.49.50.mov
It fixes microsoft/vscode-jupyter#1012.