Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WAV playback inside notebook cell #33

Closed
wants to merge 2 commits into from
Closed

Add support for WAV playback inside notebook cell #33

wants to merge 2 commits into from

Conversation

robinhad
Copy link

@robinhad robinhad commented Mar 4, 2021

This pull request adds support for WAV playback inside notebook cell.

Screen.recording.2021-03-04.12.49.50.mov

It fixes microsoft/vscode-jupyter#1012.

@ghost
Copy link

ghost commented Mar 4, 2021

CLA assistant check
All CLA requirements met.

@DonJayamanne
Copy link
Contributor

Thanks a lot @robinhad
A lot of users have requested this feature.

The one concern I have with this is the fact that we will now always render HTML & not VS Code.
There are a few drawbacks to this (styles, custom commands, links, etc) - we're now going to have to own this as well.

Once again, thanks for this PR.

@DonJayamanne
Copy link
Contributor

Starred a conversation here microsoft/vscode#118275

@robinhad
Copy link
Author

robinhad commented Mar 5, 2021

Thank you for your reply, @DonJayamanne !
Only good alternative will be to build VSCode with some kind of "libre" ffmpeg - with only wav, ogg, vorbis for audio and AV1 for video.
It will facilitate the most common use cases for audio/video processing and will not bloat VSCode too much.

@khlevon
Copy link

khlevon commented Nov 16, 2021

Hi thanks for this PR.

Can someone review and merge this PR, please?

@rchiodo

@khlevon
Copy link

khlevon commented Nov 16, 2021

@robinhad Can you please provide guide how can I use this patch like in beta mode in my workaround.

@rchiodo
Copy link
Contributor

rchiodo commented Nov 16, 2021

I don't think we're going to take this PR. We'd rather not have an html viewer in the jupyter extension. VS code should address the underlying problem instead as in this issue:

microsoft/vscode#118275

@rchiodo rchiodo closed this Nov 16, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Nov 16, 2021

@robinhad if you wanted to ship this, you could make your own renderer extension for the 'text/html' mimetype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPython.display.Audio not working for WAV audio
4 participants