Skip to content

Change default value for codingAgent.codeLens setting #7980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshspicer merged 2 commits into from
Oct 13, 2025
Merged

Change default value for codingAgent.codeLens setting #7980

joshspicer merged 2 commits into from
Oct 13, 2025

Conversation

@joshspicer
Copy link
Member

@joshspicer joshspicer commented Oct 10, 2025 •
edited
Loading

closes microsoft/vscode#271140, #7984

while #7962 is under discussion

@joshspicer joshspicer enabled auto-merge (squash) October 10, 2025 17:02
@vs-code-engineering vs-code-engineering bot added this to the October 2025 milestone Oct 10, 2025
@joshspicer joshspicer marked this pull request as draft October 10, 2025 17:17
auto-merge was automatically disabled October 10, 2025 17:17

Pull request was converted to draft

@joshspicer
Copy link
Member Author

joshspicer commented Oct 10, 2025

@copilot Fix this test

1 failing

  1. IssueTodoProvider
    should provide code lenses for TODO comments:

    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

0 !== 1

  + expected - actual

  -0
  +1

This means enabling githubPullRequests.codingAgent.codeLens for the test. Add another small test that confirms that githubPullRequests.codingAgent.codeLens === false does indeed disable the code lens.

Copilot AI mentioned this pull request Oct 10, 2025
Merged
4 tasks
Copy link
Contributor

Copilot AI commented Oct 10, 2025

@joshspicer I've opened a new pull request, #7982, to work on those changes. Once the pull request is ready, I'll request review from you.

@joshspicer
[WIP] Fix test for codingAgent.codeLens setting (#7982)
533f1ea 
* Initial plan

* Fix IssueTodoProvider test by enabling codeLens setting

Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
@joshspicer
Copy link
Member Author

joshspicer commented Oct 10, 2025

#7981 should be enough?

@joshspicer joshspicer closed this Oct 10, 2025
pubpepubpe-del

This comment was marked as off-topic.

Sign in to view

@joshspicer joshspicer reopened this Oct 13, 2025
@joshspicer joshspicer marked this pull request as ready for review October 13, 2025 15:34
@joshspicer joshspicer mentioned this pull request Oct 13, 2025
Closed
@joshspicer joshspicer merged commit 11ac6f4 into main Oct 13, 2025
6 checks passed
@joshspicer joshspicer deleted the joshspicer-patch-1 branch October 13, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitrivMS dmitrivMS dmitrivMS approved these changes

+1 more reviewer

@pubpepubpe-del pubpepubpe-del pubpepubpe-del left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joshspicer joshspicer

Labels

None yet

Projects

None yet

Milestone

October 2025

Development

Successfully merging this pull request may close these issues.

Delegate to coding agent everywhere

4 participants

@joshspicer @dmitrivMS @pubpepubpe-del