only show TODO code lens on lines that start with a comment token #7962
Conversation
|
I suggest adding |
|
nice 
|
package.json
Outdated
| "default": [ | ||
| "//", | ||
| "#", | ||
| "--", | ||
| " * ", | ||
| "///" |
There was a problem hiding this comment.
This seems suspicious. It's something that would be language specific too.
<!-- TODO: ...... -->
/*
TODO: some multi-line
comment with context
*/
<#
TODO: PowerShell block comments are weird
I know
#>
The comment syntax is declared by the language support, I feel like we should somehow leverage that if we can.
There was a problem hiding this comment.
we have this in core... and we have a number of commands in core that are about retrieval of symbols:
https://code.visualstudio.com/api/references/commands#commands
I wonder if this warrants some way to get the LanguageConfiguration via a Command. Or at least just the comment stuff...
@hediet @alexdima I see your name around this code, maybe you have ideas
There was a problem hiding this comment.
Thanks for the pointers, this looks a lot more correct.
I justified that this was ok since it's configurable via a setting and did not know we could possibly leverage core for this information.
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
I don't think we should have two setting that both control whether the code action/codelens show.
Can we instead just remove "BUG" from the list of defaults?
While #7962 is under discussion
|
@alexr00 I still think it's incorrect to match outside of a comment. Do you disagree? @TylerLeonhardt thanks for the idea/pointers |
* Initial plan * Fix IssueTodoProvider test by enabling codeLens setting Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
|
We can check if there's a comment at that position: vscode-pull-request-github/src/issues/util.ts Lines 519 to 520 in 6de5b34 |
|
isComment works great - thank you @alexr00! 
|
joshspicer
force-pushed
the
joshspicer/todo-fix
branch
from
43bc025 to
c2270dc
Compare
| const line = document.lineAt(lineNumber).text; | ||
| const textLine = document.lineAt(lineNumber); | ||
| const { text: line, firstNonWhitespaceCharacterIndex } = textLine; | ||
| if (!(await isComment(document, new vscode.Position(lineNumber, firstNonWhitespaceCharacterIndex)))) { |
There was a problem hiding this comment.
Can't decide what is more efficient/correct to do first, the comment check or the findTodoInLine() check. @alexr00 preference?
There was a problem hiding this comment.
IIRC, isComment ends up being a round trip to the renderer, so findTodoInLine is probably cheaper time-wise to do first.
* Change default value for codingAgent.codeLens setting While #7962 is under discussion * [WIP] Fix test for codingAgent.codeLens setting (#7982) * Initial plan * Fix IssueTodoProvider test by enabling codeLens setting Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
fix for #7954 being far too verbose.