Update to use eslint9

azure-pipeline.nightly.yml

@@ -31,6 +31,8 @@ extends:
 
     l10nSourcePaths: ./src
 
+    nodeVersion: "20.x"
+
     buildSteps:
       - script: yarn install --frozen-lockfile --check-files
         displayName: Install dependencies

azure-pipeline.release.yml

@@ -28,6 +28,8 @@ extends:
 
     l10nSourcePaths: ./src
 
+    nodeVersion: "20.x"
+
     buildSteps:
       - script: yarn install --frozen-lockfile --check-files
         displayName: Install dependencies

build/eslint-rules/index.js

@@ -5,7 +5,7 @@
 
 'use strict';
 
-module.exports = {
+exports.rules = {
 	'public-methods-well-defined-types': require('./public-methods-well-defined-types'),
 	'no-any-except-union-method-signature': require('./no-any-except-union-method-signature'),
 	'no-pr-in-user-strings': require('./no-pr-in-user-strings'),

build/eslint-rules/public-methods-well-defined-types.js

@@ -59,9 +59,11 @@ module.exports = {
 
 				// Type references with inline type arguments: Promise<{x: string}>, Array<{y: number}>
 				case 'TSTypeReference':
-					// Check if any type arguments contain inline types
-					if (typeNode.typeParameters && typeNode.typeParameters.params) {
-						return typeNode.typeParameters.params.some(isInlineType);
+					// ESLint 9 / @typescript-eslint v8 may expose generic instantiations on `typeArguments` instead of `typeParameters`.
+					// Support both shapes defensively.
+					const typeArgs = typeNode.typeParameters || typeNode.typeArguments;
+					if (typeArgs && typeArgs.params) {
+						return typeArgs.params.some(isInlineType);
 					}
 					return false;
 

common/views.ts

@@ -3,10 +3,10 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
+import { RemoteInfo } from './types';
 import { ClosedEvent, CommentEvent } from '../src/common/timelineEvent';
 import { GithubItemStateEnum, IAccount, ILabel, IMilestone, IProject, ITeam, MergeMethod, MergeMethodsAvailability } from '../src/github/interface';
 import { DisplayLabel, PreReviewState } from '../src/github/views';
-import { RemoteInfo } from './types';
 
 export interface CreateParams {
 	availableBaseRemotes: RemoteInfo[];