Skip to content

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Sep 27, 2025

Updates the project to use eslint 9. This switches to use a flat config instead of multiple config files. I also needed to update some of the eslint dependencies

I generally tried to keep the existing logic and rules with this change. We can revisit these later

I did end up having to make a few code changes for new errors that showed up after updating. I also have to update the PR pipeline to use node 20. The other pipeline seem to already be using node 20

Updates the package to use eslint9. This switches to a flat config file and also updates a few dependencies

I generally tried to keep the existing logic and rules with this change. We can revisit these later

I did end up having to make a few code changes for new errors that showed up after updating
@mjbvz mjbvz added this to the October 2025 milestone Sep 27, 2025
@mjbvz mjbvz requested a review from alexr00 September 27, 2025 19:39
@alexr00
Copy link
Member

alexr00 commented Sep 29, 2025

@mjbvz CI is failing

@mjbvz
Copy link
Contributor Author

mjbvz commented Sep 29, 2025

Look like the pipeline is using an old node version. Seeing if I can bump it to node 17 or newer

The release pipelines should already be using this but the pr pipeline was on an old version
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjbvz thanks for this PR! There were a couple rules that seemed to be missed, and my custom rule for the webviews wasn't running at all. I made those changes then resolved the merge conflicts.

@alexr00 alexr00 enabled auto-merge (squash) October 7, 2025 12:53
@alexr00 alexr00 merged commit 84b0372 into main Oct 7, 2025
6 checks passed
@alexr00 alexr00 deleted the dev/mjbvz/eslint9 branch October 7, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants