-
Notifications
You must be signed in to change notification settings - Fork 667
Update to use eslint9 #7876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use eslint9 #7876
Conversation
Updates the package to use eslint9. This switches to a flat config file and also updates a few dependencies I generally tried to keep the existing logic and rules with this change. We can revisit these later I did end up having to make a few code changes for new errors that showed up after updating
@mjbvz CI is failing |
Look like the pipeline is using an old node version. Seeing if I can bump it to node 17 or newer |
The release pipelines should already be using this but the pr pipeline was on an old version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjbvz thanks for this PR! There were a couple rules that seemed to be missed, and my custom rule for the webviews wasn't running at all. I made those changes then resolved the merge conflicts.
Updates the project to use eslint 9. This switches to use a flat config instead of multiple config files. I also needed to update some of the eslint dependencies
I generally tried to keep the existing logic and rules with this change. We can revisit these later
I did end up having to make a few code changes for new errors that showed up after updating. I also have to update the PR pipeline to use node 20. The other pipeline seem to already be using node 20