-
Notifications
You must be signed in to change notification settings - Fork 620
API for repository description #7066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something other users have actually asked for too, so it's cool that we'll have it. What are planning to use if for?
currentBranch?: string; | ||
pullRequest?: { | ||
title: string; | ||
url: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include number
here too? That's usually a useful thing to have.
@@ -405,19 +402,20 @@ async function deferredActivate(context: vscode.ExtensionContext, apiImpl: GitAp | |||
const showBadge = (vscode.env.appHost === 'desktop'); | |||
await credentialStore.create(showBadge ? undefined : { silent: true }); | |||
|
|||
Logger.debug('Creating tree view.', 'Activation'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log line is now not right before the tree view is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, are there any functional changes in this file?
@@ -220,4 +227,39 @@ export class GitApiImpl extends Disposable implements API, IGit { | |||
getReviewerCommentsProvider(): { title: string, provider: ReviewerCommentsProvider } | undefined { | |||
return this._reviewerCommentsProviders.size > 0 ? this._reviewerCommentsProviders.values().next().value : undefined; | |||
} | |||
|
|||
async getRepositoryDescription() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of just returning info about the first repo, I would suggest passing in a URI and returning info about the repo that the URI belongs to.
Adding an API for fetching repository description