Skip to content

Commit 8848653

Browse files
committed
Test updates
1 parent 3ed5b07 commit 8848653

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

src/test/github/folderRepositoryManager.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import { MockExtensionContext } from '../mocks/mockExtensionContext';
2222
import { Uri } from 'vscode';
2323
import { GitHubServerType } from '../../common/authentication';
2424
import { CreatePullRequestHelper } from '../../view/createPullRequestHelper';
25+
import { RepositoriesManager } from '../../github/repositoriesManager';
2526

2627
describe('PullRequestManager', function () {
2728
let sinon: SinonSandbox;
@@ -36,7 +37,8 @@ describe('PullRequestManager', function () {
3637
const repository = new MockRepository();
3738
const context = new MockExtensionContext();
3839
const credentialStore = new CredentialStore(telemetry, context);
39-
manager = new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(), credentialStore, new CreatePullRequestHelper());
40+
const repositoriesManager = new RepositoriesManager(credentialStore, telemetry);
41+
manager = new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(repositoriesManager), credentialStore, new CreatePullRequestHelper());
4042
});
4143

4244
afterEach(function () {

src/test/github/pullRequestOverview.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import { GitHubServerType } from '../../common/authentication';
2424
import { GitHubRemote } from '../../common/remote';
2525
import { CheckState } from '../../github/interface';
2626
import { CreatePullRequestHelper } from '../../view/createPullRequestHelper';
27+
import { RepositoriesManager } from '../../github/repositoriesManager';
2728

2829
const EXTENSION_URI = vscode.Uri.joinPath(vscode.Uri.file(__dirname), '../../..');
2930

@@ -45,7 +46,8 @@ describe('PullRequestOverview', function () {
4546
telemetry = new MockTelemetry();
4647
credentialStore = new CredentialStore(telemetry, context);
4748
const createPrHelper = new CreatePullRequestHelper();
48-
pullRequestManager = new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(), credentialStore, createPrHelper);
49+
const repositoriesManager = new RepositoriesManager(credentialStore, telemetry);
50+
pullRequestManager = new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(repositoriesManager), credentialStore, createPrHelper);
4951

5052
const url = 'https://github.com/aaa/bbb';
5153
remote = new GitHubRemote('origin', url, new Protocol(url), GitHubServerType.GitHubDotCom);

src/test/view/prsTree.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ describe('GitHub Pull Requests view', function () {
101101
it('has no children when repositories have not yet been initialized', async function () {
102102
const repository = new MockRepository();
103103
repository.addRemote('origin', 'git@github.com:aaa/bbb');
104-
reposManager.insertFolderManager(new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(), credentialStore, createPrHelper));
104+
reposManager.insertFolderManager(new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(reposManager), credentialStore, createPrHelper));
105105
provider.initialize([], credentialStore);
106106

107107
const rootNodes = await provider.getChildren();
@@ -111,7 +111,7 @@ describe('GitHub Pull Requests view', function () {
111111
it('opens the viewlet and displays the default categories', async function () {
112112
const repository = new MockRepository();
113113
repository.addRemote('origin', 'git@github.com:aaa/bbb');
114-
reposManager.insertFolderManager(new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(), credentialStore, createPrHelper));
114+
reposManager.insertFolderManager(new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(reposManager), credentialStore, createPrHelper));
115115
sinon.stub(credentialStore, 'isAuthenticated').returns(true);
116116
await reposManager.folderManagers[0].updateRepositories();
117117
provider.initialize([], credentialStore);
@@ -181,7 +181,7 @@ describe('GitHub Pull Requests view', function () {
181181

182182
await repository.createBranch('non-pr-branch', false);
183183

184-
const manager = new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(), credentialStore, createPrHelper);
184+
const manager = new FolderRepositoryManager(0, context, repository, telemetry, new GitApiImpl(reposManager), credentialStore, createPrHelper);
185185
reposManager.insertFolderManager(manager);
186186
sinon.stub(manager, 'createGitHubRepository').callsFake((r, cs) => {
187187
assert.deepStrictEqual(r, remote);

src/test/view/reviewCommentController.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ describe('ReviewCommentController', function () {
7878
const activePrViewCoordinator = new WebviewViewCoordinator(context);
7979
const createPrHelper = new CreatePullRequestHelper();
8080
Resource.initialize(context);
81-
gitApiImpl = new GitApiImpl();
81+
gitApiImpl = new GitApiImpl(reposManager);
8282
manager = new FolderRepositoryManager(0, context, repository, telemetry, gitApiImpl, credentialStore, createPrHelper);
8383
reposManager.insertFolderManager(manager);
8484
const tree = new PullRequestChangesTreeDataProvider(gitApiImpl, reposManager);

0 commit comments

Comments
 (0)