Skip to content

deduplicate diff test messages #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdneo merged 3 commits into from
Jan 30, 2023
Merged

deduplicate diff test messages #1521

jdneo merged 3 commits into from
Jan 30, 2023

Conversation

@fladdimir
Copy link
Contributor

@fladdimir fladdimir commented Jan 20, 2023 •
edited
Loading

resolves #1522

@fladdimir fladdimir mentioned this pull request Jan 20, 2023
Merged
@fladdimir
Copy link
Contributor Author

fladdimir commented Jan 23, 2023 •
edited
Loading

@jdneo first idea on how to fix the duplication of diff-test-messages for assertion errors, let me know what you think

(not sure whether it's easier / less manual testing effort to incorporate this fix into #1519, or whether these two PRs should be kept separated?)

fladdimir
fladdimir commented Jan 23, 2023
View reviewed changes
fladdimir
fladdimir commented Jan 23, 2023
View reviewed changes
@fladdimir fladdimir force-pushed the fix/deduplicate-diff-test-messages branch from 7bc565a to 48512db Compare January 29, 2023 15:01
@fladdimir fladdimir marked this pull request as ready for review January 29, 2023 15:11
jdneo
jdneo approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fladdimir for your contribution!

The change looks good to me, and it makes the logic clearer than before. 👍

@jdneo jdneo merged commit d8fda1a into microsoft:main Jan 30, 2023
@jdneo jdneo added the bug label Jan 30, 2023
@jdneo jdneo added this to the 0.38.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdneo jdneo jdneo approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

0.38.1

Development

Successfully merging this pull request may close these issues.

Bug: diff-test-messages for assertion failures may be duplicated

2 participants

@fladdimir @jdneo