Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Adopt to the new VS Code tests API #1257

Merged
merged 22 commits into from
Aug 3, 2021
Merged

refactor: Adopt to the new VS Code tests API #1257

merged 22 commits into from
Aug 3, 2021

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Aug 3, 2021

address #1162

@jdneo jdneo added this to the 0.31.0 milestone Aug 3, 2021
@jdneo jdneo requested a review from Eskibear August 3, 2021 05:19
Eskibear
Eskibear previously approved these changes Aug 3, 2021
@jdneo jdneo merged commit fda8aff into main Aug 3, 2021
@mfussenegger
Copy link

mfussenegger commented Aug 3, 2021

I think this might have caused a regression. Retrieving the junit arguments now takes a lot longer:

[2021-08-03T20:21:21+0200] "vscode.java.test.junit.argument", "start"
[2021-08-03T20:22:07+0200] "vscode.java.test.junit.argument", "finished"

That's almost 50 seconds.

Compared to the latest version on the master branch (instead of main):

[2021-08-03T20:25:55+0200] "vscode.java.test.junit.argument", "start"
[2021-08-03T20:25:55+0200] "vscode.java.test.junit.argument", "finished"

That only took a couple of ms.

I took a profile from the main branch:

image

And one from before:

image

I tested this with nvim-jdtls (with mfussenegger/nvim-jdtls#108) on the CrateDB code base. (Within the PlannerTest class)

mfussenegger added a commit to mfussenegger/nvim-jdtls that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants