-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Adopt to the new VS Code tests API #1257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
previously approved these changes
Aug 3, 2021
Eskibear
approved these changes
Aug 3, 2021
I think this might have caused a regression. Retrieving the junit arguments now takes a lot longer:
That's almost 50 seconds. Compared to the latest version on the
That only took a couple of ms. I took a profile from the main branch: And one from before: I tested this with nvim-jdtls (with mfussenegger/nvim-jdtls#108) on the CrateDB code base. (Within the |
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Aug 3, 2021
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Aug 9, 2021
dradtke
added a commit
to dradtke/vim-dap
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #1162