Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize the repo #1237

Merged
merged 1 commit into from
Jul 27, 2021
Merged

initialize the repo #1237

merged 1 commit into from
Jul 27, 2021

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Jul 27, 2021

No description provided.

@jdneo jdneo merged commit b25e099 into cs/1.0.0-feature Jul 27, 2021
@jdneo jdneo deleted the cs/1.0.0-init branch July 27, 2021 09:11
@@ -26,10 +26,6 @@
public class TestDelegateCommandHandler implements IDelegateCommandHandler {

private static final String GET_TEST_SOURCE_PATH = "vscode.java.test.get.testpath";
private static final String SEARCH_TEST_ITEMS = "vscode.java.test.search.items";
private static final String SEARCH_TEST_ALL_ITEMS = "vscode.java.test.search.items.all";
private static final String SEARCH_TEST_CODE_LENS = "vscode.java.test.search.codelens";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is vscode.java.test.search.codelens going to be removed for god?

I use this in nvim-jdtls to provide test_nearest_function and test_class methods

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the background is that VS Code is proposing a new set of testing APIs, so we are adopting to it. To match the data model, we need to update our backend logics.

But there is a new method to replace it, which will be added later. See: https://github.com/jdneo/vscode-java-test/blob/cs/new-test-api/java-extension/com.microsoft.java.test.plugin/src/main/java/com/microsoft/java/test/plugin/util/TestSearchUtils.java#L277-L325

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the answer. I'm glad that there is going to be a replacement 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfussenegger

Just FYI that the new refactored code has been merged into the main branch. The previous vscode.java.test.search.codelens is replaced by findTestTypesAndMethods(), actually their implementation logic is very similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants