new UX to configure java runtime #791
Conversation
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
|
|
There was a problem hiding this comment.
Don't forget to update the TPN.
And some UI feedback from my personal opinion:
The hint icon's position is not aligned with the text, and make it as a button looks strange to me because nothing will happen after clicking it.
The size of the drop down list is too small, can we make it the same as the cell's width?
|
|
||
| onClickBrowseJDKButton = () => { | ||
| onWillBrowseForJDK(); | ||
| this.setState({ isDirty: true }); |
There was a problem hiding this comment.
We can do better only set this flag to true when a valid JDK is selected.
There was a problem hiding this comment.
it's picked from local disk, which is known by extension proccess.
If we want to do that, the workflow would be:
- extension validate selected JDK.
- extension posts message to webview.
- webview update state.
There was a problem hiding this comment.
Yes the workflow is exactly what I was thinking when I left the comment
|
Some more feedback:
|
I was using components from webview-toolkit-ui. I'll fine-tune it if I had time.
It's on purpose. The content is |
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
|
Now: I'll create a new PR to add Install JDK webview, which looks like below shown aside: |
| hasBuildTool(p) ? | ||
| <div className="inline-flex"> | ||
| <span>{p.sourceLevel}</span> | ||
| <Button appearance="icon" onClick={() => this.onClickEdit(p)}><span className="codicon codicon-edit"></span></Button> |
There was a problem hiding this comment.
We can have a tooltip for this button as well
|
I tried to open runtime page for petclinic and see this:
Seems caused by the JDT.LS not activated, though I don't know why 🤔 |
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
|
futher actions tracked in #798 |
No description provided.