Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable long running tests and use new federated credentials for testing #864

Merged
merged 59 commits into from
May 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
f8b7ada
WIP: Get token credential from SP
nturinski Apr 26, 2024
666331d
WIP: See is test provider can sign in
nturinski Apr 29, 2024
ab7d2b3
WIP: Remove webConfig, dont import dev into production code
nturinski Apr 29, 2024
6f26be0
WIP: Remove web entry point from package.json
nturinski Apr 29, 2024
b430191
Add await to the logIn
nturinski Apr 29, 2024
e736093
Add listing tests
nturinski Apr 30, 2024
5702f73
Fix up resource listing test
nturinski Apr 30, 2024
818c9d8
Update service connection
nturinski Apr 30, 2024
fb86ea2
Hardcode long running tests
nturinski Apr 30, 2024
70ea454
Add some console.debug
nturinski Apr 30, 2024
565b639
Make token static
nturinski Apr 30, 2024
914981e
Test code
nturinski May 2, 2024
a3f8c03
Add default
nturinski May 2, 2024
88ddc26
Add resource provider to global test
nturinski May 2, 2024
b02c6eb
Use the resource provider instead of trying to calling it directly
nturinski May 2, 2024
1461993
Try using the key vault values
nturinski May 3, 2024
e39f237
Use fetch and see response type
nturinski May 3, 2024
703699a
Dont parse response2
nturinski May 3, 2024
383bf52
wip
nturinski May 3, 2024
d09823b
Add node-fetch as a resource
nturinski May 3, 2024
bfb4815
Make token code use function
nturinski May 3, 2024
3e5a7fe
Use service client from @azure/core-client
nturinski May 6, 2024
dcd9520
Final test using service client
nturinski May 6, 2024
941b5ba
Remove unused context
nturinski May 6, 2024
ae77264
Confirm access token is being made
nturinski May 6, 2024
1e6b7a8
Leverage auth package
nturinski May 7, 2024
12e4fd7
Add create and delete tests for Resource Groups
nturinski May 9, 2024
1dde188
Merge main
nturinski May 9, 2024
511c8e2
Comments
nturinski May 9, 2024
5b043ed
Import settingUtils from bundle
nturinski May 9, 2024
8d072e8
Import LocationListStep from bundle?
nturinski May 9, 2024
8a34174
Reorganize and remove some inports from bundle
nturinski May 9, 2024
b676b40
Add hasPortalUrl
nturinski May 9, 2024
9d443e2
See if there are any build errors
nturinski May 9, 2024
7a0c045
Merge branch 'main' of https://github.com/microsoft/vscode-azureresou…
nturinski May 9, 2024
7870694
use auth refactor
hossam-nasr May 14, 2024
53b89af
update package json
hossam-nasr May 14, 2024
c222174
use newly released auth package
hossam-nasr May 16, 2024
082f9fa
use parameter
hossam-nasr May 16, 2024
96ef64f
Merge branch 'main' into hossamnasr/useNewConstructor
hossam-nasr May 16, 2024
c5f542b
remove installing azure account
hossam-nasr May 16, 2024
5940e78
remove pretest step
hossam-nasr May 16, 2024
6b345a3
remove installing azure account fr fr
hossam-nasr May 16, 2024
53a928d
remove from recommendations
hossam-nasr May 16, 2024
8108fad
reintroduce gulp
hossam-nasr May 16, 2024
717d7e1
nuclear warfare
hossam-nasr May 17, 2024
7619718
add webpack to pretest
hossam-nasr May 17, 2024
aa343d7
logs
hossam-nasr May 17, 2024
c73b107
try logging error
hossam-nasr May 17, 2024
9ba3554
use the new env vars with the underscore
hossam-nasr May 17, 2024
efaf5d9
don't swallow errors
hossam-nasr May 23, 2024
46ae5d4
cleanup
hossam-nasr May 23, 2024
7e62b84
only set to true when doing azure federated credentials
hossam-nasr May 23, 2024
adf99a1
use new branch for quick testing
hossam-nasr May 23, 2024
8c5d849
use main again
hossam-nasr May 23, 2024
2bd383d
refactor subscription provider logic
hossam-nasr May 23, 2024
f33e2dc
remove commented out code
hossam-nasr May 23, 2024
82410be
set in the helper
hossam-nasr May 24, 2024
9dc02eb
make optional
hossam-nasr May 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't swallow errors
  • Loading branch information
hossam-nasr committed May 23, 2024
commit efaf5d960bc5ef25889263546f33493b3534351d
2 changes: 2 additions & 0 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ export async function activate(context: vscode.ExtensionContext, perfStats: { lo
// TODO: Use the other environment variable to determine to use this. Currently set to true for testing reasons
const longRunningTestsEnabled: boolean = true;//!/^(false|0)?$/i.test(process.env.ENABLE_LONG_RUNNING_TESTS || '')
if (longRunningTestsEnabled) {
// when running tests, ensure we throw the errors and they aren't silently swallowed
hossam-nasr marked this conversation as resolved.
Show resolved Hide resolved
activateContext.errorHandling.rethrow = true;
try {
console.log("TEST: Accessing env vars");
const serviceConnectionId: string | undefined = process.env['AzCode_ServiceConnectionID'];
Expand Down