Enable long running tests and use new federated credentials for testing #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hossam-nasr
commented
May 23, 2024
| @@ -27,3 +27,5 @@ resources: | |||
| # Use those templates | |||
| extends: | |||
| template: azure-pipelines/1esmain.yml@azExtTemplates | |||
| parameters: | |||
| useAzureFederatedCredentials: true | |||
There was a problem hiding this comment.
If you look at the rest of the file, this pipeline file is only run when scheduled for nightly builds. Normal build pipelines that occur on PRs are done through GitHub Actions and not through this file. This is why useAzureFederatedCredentials is always set to true. For completeness sake, we could also set it to only be true if the build reason is Schedule, but that would make it harder to test manually for any reason
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "recommendations": [ | |||
| "dbaeumer.vscode-eslint", | |||
| "ms-vscode.azure-account" | |||
There was a problem hiding this comment.
no longer need this recommendation
| @@ -50,6 +50,5 @@ async function cleanReadme(): Promise<void> { | |||
|
|
|||
| exports['webpack-dev'] = gulp.series(prepareForWebpack, () => gulp_webpack('development')); | |||
| exports['webpack-prod'] = gulp.series(prepareForWebpack, () => gulp_webpack('production')); | |||
| exports.preTest = gulp_installAzureAccount; | |||
There was a problem hiding this comment.
We no longer need to install Azure Account before tests
| { | ||
| encoding: 'utf-8', | ||
| stdio: 'inherit' | ||
| }); |
There was a problem hiding this comment.
No longer need to install Azure Account before running tests
nturinski
reviewed
May 23, 2024
nturinski
reviewed
May 23, 2024
nturinski
previously approved these changes
May 23, 2024
nturinski
approved these changes
May 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the newly created
AzureDevOpsSubscriptionProviderfrom the most recent release of theauthpackage, and creates some simple CRUD E2E tests. In addition, it also:webpackas a pretest step