-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable long running tests and use new federated credentials for testing #864
Conversation
@@ -27,3 +27,5 @@ resources: | |||
# Use those templates | |||
extends: | |||
template: azure-pipelines/1esmain.yml@azExtTemplates | |||
parameters: | |||
useAzureFederatedCredentials: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the rest of the file, this pipeline file is only run when scheduled for nightly builds. Normal build pipelines that occur on PRs are done through GitHub Actions and not through this file. This is why useAzureFederatedCredentials
is always set to true
. For completeness sake, we could also set it to only be true if the build reason is Schedule
, but that would make it harder to test manually for any reason
@@ -1,6 +1,5 @@ | |||
{ | |||
"recommendations": [ | |||
"dbaeumer.vscode-eslint", | |||
"ms-vscode.azure-account" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer need this recommendation
@@ -50,6 +50,5 @@ async function cleanReadme(): Promise<void> { | |||
|
|||
exports['webpack-dev'] = gulp.series(prepareForWebpack, () => gulp_webpack('development')); | |||
exports['webpack-prod'] = gulp.series(prepareForWebpack, () => gulp_webpack('production')); | |||
exports.preTest = gulp_installAzureAccount; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer need to install Azure Account before tests
{ | ||
encoding: 'utf-8', | ||
stdio: 'inherit' | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer need to install Azure Account before running tests
This PR uses the newly created
AzureDevOpsSubscriptionProvider
from the most recent release of theauth
package, and creates some simple CRUD E2E tests. In addition, it also:webpack
as a pretest step