[arrow] enable building on Windows ARM64 #47750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2025
jgiannuzzi
force-pushed
the
arrow-windows-arm64
branch
from
515c015 to
83b40db
Compare
- vendored pcg is patched to support msvc arm64 intrinsics - ARROW_SIMD_LEVEL is set to NONE to disable the use of xsimd, which does not yet support msvc arm64 intrinsics (non-trivial to add)
jgiannuzzi
force-pushed
the
arrow-windows-arm64
branch
from
83b40db to
82acc18
Compare
Comment on lines
+36
to
+37
| + uint64_t lo = a.d.v01 * b.d.v01; | ||
| + uint64_t hi = __umulh(a.d.v01, b.d.v01); |
Contributor
There was a problem hiding this comment.
Is there an upstream PR for these changes? Additionally, vendored libraries should be devendored as much as possible in vcpkg. I do see we have a pcg port. Should this be using that instead?
Member
There was a problem hiding this comment.
I think this change is correct but I would still like to see upstream at least notified before merging this.
Contributor
Author
There was a problem hiding this comment.
Yes, the upstream PR is here: apache/arrow#47779
BillyONeal
approved these changes
Oct 13, 2025
Member
|
Thanks! |
Contributor
Author
|
Thanks for the merge @BillyONeal! |
pitrou
pushed a commit
to apache/arrow
that referenced
this pull request
Oct 15, 2025
…nsics (#47779) ### Rationale for this change This change enables building Arrow C++ for Windows ARM64 with MSVC when setting `ARROW_SIMD_LEVEL` to `NONE`. This is useful to be able to build Arrow with `vcpkg` and use it as a dependency. Setting `ARROW_SIMD_LEVEL` to `NONE` is done to disable the use of `xsimd`, which does not yet support msvc arm64 intrinsics, and is non-trivial to fix. ### What changes are included in this PR? A patch to the vendored `pcg` library, based on imneme/pcg-cpp#99. The upstream pcg library has not been updated in the past 3 years, so this may never get merged. ### Are these changes tested? Yes, the changes have been tested in microsoft/vcpkg#47750 (the same patch for `vcpkg`, which this change would alleviate) and in https://github.com/jgiannuzzi/ParquetSharp/actions/runs/18354286294 (a full run of the ParquetSharp CI, using this patch to build Arrow with `vcpkg`). ### Are there any user-facing changes? Not really, unless you consider adding the ability to build Arrow on Windows ARM64 user-facing? * GitHub Issue: #47784 Authored-by: Jonathan Giannuzzi <jonathan@giannuzzi.me> Signed-off-by: Antoine Pitrou <antoine@python.org>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Nov 5, 2025
… intrinsics (apache#47779) ### Rationale for this change This change enables building Arrow C++ for Windows ARM64 with MSVC when setting `ARROW_SIMD_LEVEL` to `NONE`. This is useful to be able to build Arrow with `vcpkg` and use it as a dependency. Setting `ARROW_SIMD_LEVEL` to `NONE` is done to disable the use of `xsimd`, which does not yet support msvc arm64 intrinsics, and is non-trivial to fix. ### What changes are included in this PR? A patch to the vendored `pcg` library, based on imneme/pcg-cpp#99. The upstream pcg library has not been updated in the past 3 years, so this may never get merged. ### Are these changes tested? Yes, the changes have been tested in microsoft/vcpkg#47750 (the same patch for `vcpkg`, which this change would alleviate) and in https://github.com/jgiannuzzi/ParquetSharp/actions/runs/18354286294 (a full run of the ParquetSharp CI, using this patch to build Arrow with `vcpkg`). ### Are there any user-facing changes? Not really, unless you consider adding the ability to build Arrow on Windows ARM64 user-facing? * GitHub Issue: apache#47784 Authored-by: Jonathan Giannuzzi <jonathan@giannuzzi.me> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
pcgis patched to support msvc arm64 intrinsicsARROW_SIMD_LEVELis set toNONEto disable the use ofxsimd, whichdoes not yet support msvc arm64 intrinsics (non-trivial to add)
Port update checklist
./vcpkg x-add-version --alland committing the result.