Skip to content

Comments

[arrow] remove windows dependency for mimalloc feature#46299

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
pratikpc:arrow/mimalloc-dependnecy-windows-remove
Jul 6, 2025
Merged

[arrow] remove windows dependency for mimalloc feature#46299
vicroms merged 1 commit intomicrosoft:masterfrom
pratikpc:arrow/mimalloc-dependnecy-windows-remove

Conversation

@pratikpc
Copy link
Contributor

@pratikpc pratikpc commented Jul 5, 2025 •
edited
Loading

Fixes #46298

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@pratikpc pratikpc marked this pull request as ready for review July 6, 2025 02:33
@pratikpc
Copy link
Contributor Author

pratikpc commented Jul 6, 2025

Hi I have marked the PR as ready but am not very sure if any CI base line changes need to be made

vicroms
vicroms requested changes Jul 6, 2025
View reviewed changes
@vicroms vicroms self-assigned this Jul 6, 2025
@vicroms vicroms added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jul 6, 2025
@vicroms vicroms marked this pull request as draft July 6, 2025 03:43
@pratikpc pratikpc requested a review from vicroms July 6, 2025 07:50
@pratikpc pratikpc marked this pull request as ready for review July 6, 2025 08:06
@pratikpc
Copy link
Contributor Author

pratikpc commented Jul 6, 2025

@dg0yt @vicroms thanks!!!!

@vicroms vicroms merged commit e08b7bd into microsoft:master Jul 6, 2025
18 checks passed
@pratikpc pratikpc deleted the arrow/mimalloc-dependnecy-windows-remove branch July 7, 2025 03:05
@adamreeve adamreeve mentioned this pull request Jul 7, 2025
Merged
talregev pushed a commit to talregev/vcpkg that referenced this pull request Aug 11, 2025
@pratikpc @talregev
[arrow] remove windows dependency for mimalloc feature (microsoft#46299)
808cbfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicroms vicroms vicroms approved these changes

+1 more reviewer

@dg0yt dg0yt dg0yt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vicroms vicroms

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[arrow] mimalloc feature does not depend on windows

3 participants

@pratikpc @vicroms @dg0yt