Build Arrow with support for mimalloc and jemalloc#540
Merged
adamreeve merged 5 commits intoG-Research:masterfrom Jul 7, 2025
Merged
Build Arrow with support for mimalloc and jemalloc#540adamreeve merged 5 commits intoG-Research:masterfrom
adamreeve merged 5 commits intoG-Research:masterfrom
Conversation
adamreeve
commented
Jul 7, 2025
| var pool = MemoryPool.GetDefaultMemoryPool(); | ||
|
|
||
| Assert.AreEqual(0, pool.BytesAllocated); | ||
| Assert.Greater(pool.MaxMemory, 0); |
Contributor
Author
There was a problem hiding this comment.
This was incorrect even with the system allocator and only passed when other tests had been run previously and allocated memory.
adamreeve
commented
Jul 7, 2025
| "name": "parquetsharp", | ||
| "version-string": "undefined", | ||
| "builtin-baseline": "d9ccd77bb554e67137f3f754a2e2f11f4188c82c", | ||
| "builtin-baseline": "e08b7bd89ae162f8579df2f8d39a1ae94107c8fd", |
Contributor
Author
There was a problem hiding this comment.
Needed to bump the baseline to pick up this fix that allows using mimalloc on non-Windows: microsoft/vcpkg#46299
jgiannuzzi
approved these changes
Jul 7, 2025
marcin-krystianc
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means the default allocator will now be mimalloc, matching upstream Arrow on platforms where we enable it. Users can switch allocators with the
ARROW_DEFAULT_MEMORY_POOLenvironment variable.Mimalloc and jemalloc should work on arm64, but it appears that these don't build correctly when cross-compiling on an x64 host as part of the Arrow build. Arrow doesn't use mimalloc or jemalloc from vcpkg but always builds its own version, so this probably needs some fixes to the upstream Arrow build scripts.