Skip to content

[open62541] Update to 1.4.11 #45011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gav2xlin
Copy link

@gav2xlin gav2xlin commented Apr 13, 2025

New open62541 version: 1.4.11

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@gav2xlin gav2xlin marked this pull request as draft April 13, 2025 17:16
@gav2xlin gav2xlin force-pushed the open62541_update_1_4_11 branch from 224a926 to 5546b1a Compare April 13, 2025 17:28
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Apr 14, 2025
@Cheney-W
Copy link
Contributor

The latest version of open62541 is v1.4.11.1, could you please update to this version?
Also, those failed triplets all failed for the same reason:

CMake Error at cmake_install.cmake:36 (MESSAGE):
  Installation with UA_ENABLE_AMALGAMATION=ON is not possible.

Perhaps adding -DUA_ENABLE_AMALGAMATION=OFF to vcpkg_cmake_configure() could fix the issue.

@BillyONeal
Copy link
Member

Possibly related? #44965

@gav2xlin gav2xlin force-pushed the open62541_update_1_4_11 branch from 5546b1a to a100147 Compare April 15, 2025 12:02
@gav2xlin
Copy link
Author

gav2xlin commented Apr 15, 2025

The latest version of open62541 is v1.4.11.1, could you please update to this version? Also, those failed triplets all failed for the same reason:

CMake Error at cmake_install.cmake:36 (MESSAGE):
  Installation with UA_ENABLE_AMALGAMATION=ON is not possible.

Perhaps adding -DUA_ENABLE_AMALGAMATION=OFF to vcpkg_cmake_configure() could fix the issue.

@Cheney-W done

I wanted to update Qt to the version 6.9.0, but it is like a cross dependency 🤔 (+ kdstatemachineeditor is not compiled with Qt 6.9)

https://dev.azure.com/vcpkg/public/_build/results?buildId=114663&view=logs&j=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad&t=73c5513e-c47c-57a4-379a-581f7e429f13
"error: building qtopcua:x64-linux failed with: BUILD_FAILED"

@dg0yt
Copy link
Contributor

dg0yt commented Apr 15, 2025

These problems are connected:

UA_ENABLE_AMALGAMATION is controlled by feature amalgamation.
But for installation (as done by a port) it was "not recommended" in 1.3.15 and is "not possible" in 1.4.11.

qtopcua depends on open62541[amalgamation] and now it fails with

/mnt/vcpkg-ci/b/qtopcua/src/qtopcua-v6-245310f428.clean/src/plugins/opcua/open62541/qopen62541.h:21:10: fatal error: open62541.h: No such file or directory
   21 | #include <open62541.h>

Well, it is UA_ENABLE_AMALGAMATION which generates open62541.h.

To continue,

  • the amalgamation feature must be removed, even from the current port version IMO. (Not recommended = unsupported.)
  • qtopcua must be modified to use individual headers. (Maybe this could be achieved by putting a single suitable header in the source or binary dir?)

@dg0yt
Copy link
Contributor

dg0yt commented Apr 15, 2025

#45059

@gav2xlin gav2xlin force-pushed the open62541_update_1_4_11 branch from a100147 to f3a6291 Compare April 17, 2025 05:06
gav2xlin and others added 3 commits April 17, 2025 19:03
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants