Skip to content

[aws-c-cal] Remove OpenSSL dependency from Windows and macOS. #44996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

[aws-c-cal] Remove OpenSSL dependency from Windows and macOS. #44996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99e58a4
[aws-c-cal] Remove OpenSSL dependency from Windows and macOS.
teo-tsirpanis Apr 11, 2025
7573f6a
Update versions database.
teo-tsirpanis Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ports/aws-c-cal/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@ vcpkg_from_github(
PATCHES remove-libcrypto-messages.patch
)

if (NOT (VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_OSX))
set(USE_OPENSSL ON)
endif()
Comment on lines +10 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider adding a feature for using OpenSSL on those platforms since they can often be behind on algorithm support in system libs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my initial idea actually, but on second thought I think we should add this feature only if someone asks for it. We should not enable poor security practices, and the only algorithm supported only by OpenSSL is Ed25519, which has no uses in public GitHub repos that are not bindings of aws-c-cal.


vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
"-DCMAKE_MODULE_PATH=${CURRENT_INSTALLED_DIR}/share/aws-c-common" # use extra cmake files
-DBUILD_TESTING=FALSE
-DUSE_OPENSSL=ON
-DUSE_OPENSSL=${USE_OPENSSL}
)

vcpkg_cmake_install()
Expand Down
6 changes: 5 additions & 1 deletion ports/aws-c-cal/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"name": "aws-c-cal",
"version": "0.8.8",
"port-version": 1,
"description": "C99 wrapper for cryptography primitives.",
"homepage": "https://github.com/awslabs/aws-c-cal",
"license": "Apache-2.0",
"dependencies": [
"aws-c-common",
"openssl",
{
"name": "openssl",
"platform": "!windows & !osx"
},
{
"name": "vcpkg-cmake",
"host": true
Expand Down
5 changes: 5 additions & 0 deletions versions/a-/aws-c-cal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "89bfec3f208df540aae6e782cc9e993b29580c5a",
"version": "0.8.8",
"port-version": 1
},
{
"git-tree": "b4f501b994ed102042e7d3ed48c41a5b49ea88e2",
"version": "0.8.8",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@
},
"aws-c-cal": {
"baseline": "0.8.8",
"port-version": 0
"port-version": 1
},
"aws-c-common": {
"baseline": "0.12.2",
Expand Down