[aws-c-cal] Remove OpenSSL dependency from Windows and macOS. #44996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+10
to
+12
| if (NOT (VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_OSX)) | ||
| set(USE_OPENSSL ON) | ||
| endif() |
There was a problem hiding this comment.
Maybe consider adding a feature for using OpenSSL on those platforms since they can often be behind on algorithm support in system libs?
There was a problem hiding this comment.
That was my initial idea actually, but on second thought I think we should add this feature only if someone asks for it. We should not enable poor security practices, and the only algorithm supported only by OpenSSL is Ed25519, which has no uses in public GitHub repos that are not bindings of aws-c-cal.
LilyWangLL
added
the
category:port-feature
LilyWangLL
approved these changes
Apr 14, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.Partially reverts #43559. Using system crypto libraries where available is better for security and results in compiling less code.
c.c. @fran6co