Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vamp-sdk] install pkgconfig files #23331

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

Adela0814
Copy link
Contributor

Fix #22653

install pkgconfig file:

vamp.pc
vamp-hostsdk.pc
vamp-sdk.pc

@Adela0814 Adela0814 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Mar 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vamp-sdk/vcpkg.json

Valid values for the license field can be found in the documentation

@Cheney-W Cheney-W marked this pull request as ready for review March 1, 2022 09:29
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 1, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ras0219-msft ras0219-msft added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 2, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vamp-sdk/vcpkg.json

Valid values for the license field can be found in the documentation

@dg0yt
Copy link
Contributor

dg0yt commented Mar 2, 2022

Does vamp-hostsdk.pc provide useful information given vcpkg's split of host triplet and target triplet?

@Adela0814
Copy link
Contributor Author

@dg0yt They are different libraries and has different sources.

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 2, 2022
@dg0yt
Copy link
Contributor

dg0yt commented Mar 2, 2022

@dg0yt They are different libraries and has different sources.

Sure. But it doesn't invalidate my question. I could rephrase:
Does vamp-hostsdk.pc relate to tools or libs to be used on the host?

@JackBoosY
Copy link
Contributor

@dg0yt Nope, their add_library are unconditional.

@vicroms vicroms merged commit 188617d into microsoft:master Mar 2, 2022
@Be-ing
Copy link
Contributor

Be-ing commented Mar 3, 2022

Does vamp-hostsdk.pc relate to tools or libs to be used on the host?

"Host" in this context means an application that hosts plugins. It is unrelated to vcpkg's term "host".

@Adela0814 Adela0814 deleted the Dev/Mengna/vamp-sdk branch January 16, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vamp-sdk] pkgconfig files not installed
8 participants