-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI3 with emitter framework (for schemas) #2547
Merged
timotheeguerin
merged 31 commits into
microsoft:main
from
timotheeguerin:openapi3/emitter-framework
Nov 16, 2023
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
76dfaad
initial primitive types
timotheeguerin f293673
v1
timotheeguerin b46fd4a
progress
timotheeguerin 7e728a7
model prop ref
timotheeguerin 7826502
progress
timotheeguerin 77b9ec2
Handle enums
timotheeguerin ba578ab
Handle unions minus visibility
timotheeguerin 4058afe
Slight cleanup
timotheeguerin 137303b
visibility
timotheeguerin e031f9a
Visibility progress
timotheeguerin e1b661f
Deal with visibility
timotheeguerin b7ef682
Fix bleed
timotheeguerin 6ef6971
Significant progress
timotheeguerin 0c81151
fix dup schema error
timotheeguerin 5607d52
Merge branch 'main' of https://github.com/Microsoft/typespec into ope…
timotheeguerin 48c827d
wip
timotheeguerin 8ba77ac
Merge with main
timotheeguerin e49aba6
More
timotheeguerin b472367
Merge branch 'main' into openapi3/emitter-framework
timotheeguerin 098374f
Merge branch 'main' of https://github.com/Microsoft/typespec into ope…
timotheeguerin b11a2c3
Regen samples and add circular ref
timotheeguerin f5ea145
Merge branch 'main' of https://github.com/Microsoft/typespec into ope…
timotheeguerin 7b52ba8
fix
timotheeguerin 0c7713a
Fix test
timotheeguerin 456af2b
.
timotheeguerin 533a5a1
Merge branch 'main' into openapi3/emitter-framework
timotheeguerin d63d84d
Merge branch 'main' into openapi3/emitter-framework
timotheeguerin 9a57149
Merge branch 'main' into openapi3/emitter-framework
timotheeguerin 6bfae21
changelog
timotheeguerin 534f49c
Merge branch 'main' into openapi3/emitter-framework
timotheeguerin e5ac05c
cleanup cr
timotheeguerin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
common/changes/@typespec/compiler/openapi3-emitter-framework_2023-11-06-20-02.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"changes": [ | ||
{ | ||
"packageName": "@typespec/compiler", | ||
"comment": "Emitter framework: Allow passing a custom context when calling `emitType` ", | ||
"type": "none" | ||
} | ||
], | ||
"packageName": "@typespec/compiler" | ||
} |
10 changes: 10 additions & 0 deletions
10
common/changes/@typespec/openapi3/openapi3-emitter-framework_2023-11-06-20-02.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"changes": [ | ||
{ | ||
"packageName": "@typespec/openapi3", | ||
"comment": "Migrate code to use the emitter framework", | ||
"type": "none" | ||
} | ||
], | ||
"packageName": "@typespec/openapi3" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to handle context's lexicalContext as well?