OpenAPI3 with emitter framework (for schemas) #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…napi3/emitter-framework
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2547/ |
timotheeguerin
commented
Oct 9, 2023
timotheeguerin
commented
Oct 9, 2023
timotheeguerin
commented
Oct 9, 2023
…napi3/emitter-framework
…napi3/emitter-framework
timotheeguerin
changed the title
timotheeguerin
requested review from
bterlson,
daviwil,
markcowl and
allenjzhang
as code owners
timotheeguerin
commented
Oct 30, 2023
packages/samples/test/output/grpc-library-example/@typespec/openapi3/openapi.yaml
Show resolved
Hide resolved
bterlson
reviewed
Nov 15, 2023
bterlson
reviewed
Nov 15, 2023
| return sourceFiles; | ||
| }, | ||
|
|
||
| emitType(type, context?: ContextState) { |
There was a problem hiding this comment.
Don't you need to handle context's lexicalContext as well?
bterlson
approved these changes
Nov 15, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2563
Laborious conversion of the openapi3 emitter to use the emitter framework and hopefully have a cleaner experience
TODO: