Support the array spread operator #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- An alternate approach would be to make arrayElementList contain a class that is either an ArrayElement or an UnpackExpression (new Node used only for this). That would also work for me, but changing ArrayElement seemed simpler and less likely to cause crashes in other existing applications. Add tests of this operator and error handling. See https://wiki.php.net/rfc/spread_operator_for_array
roblourens
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate approach would be to make arrayElementList contain a class
that is either an ArrayElement or an UnpackExpression (new Node used
only for this).
That would also work for me,
but changing ArrayElement seemed simpler and less likely to cause crashes in
other existing applications.
Add tests of this operator and error handling.
See https://wiki.php.net/rfc/spread_operator_for_array