Skip to content

Support parsing PHP 7.4's arrow functions #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

TysonAndre
Copy link
Contributor

This requires PHP 7.4-dev from May 2nd or later.

Add various test cases of this working,
as well as tests of error tolerance.

Fixes #291

This requires PHP 7.4-dev from May 2nd or later.

Add various test cases of this working,
as well as tests of error tolerance.

Fixes microsoft#291
@TysonAndre
Copy link
Contributor Author

@roblourens - Any feedback for this and #294 ?

@TysonAndre
Copy link
Contributor Author

@roblourens - Any feedback for this and #294 and #295 ?

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long to get to this. When I don't respond, you can just keep pinging me... 😁

@roblourens roblourens merged commit 5457e82 into microsoft:master Jul 1, 2019
@TysonAndre TysonAndre deleted the parse-arrow-function branch March 27, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PHP 7.4 arrow functions (fn($x) => expr)
2 participants