Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting Fixes for 1.2.1 #396

Merged
merged 7 commits into from
Apr 3, 2018
Merged

Porting Fixes for 1.2.1 #396

merged 7 commits into from
Apr 3, 2018

Conversation

mayankbansal018 and others added 7 commits April 2, 2018 19:32
* Base commit

* Adding Unit Test

* PR comments

* Adding logs for diagnostics

* Ignoring Test Temporarily

* Removing ignore

# Conflicts:
#	test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestExecutionManagerTests.cs
#372)

* Today even if classInit wasnt called we used to call class cleanup. fixing that and adding a test to cover the scenario
# Conflicts:
#	src/Adapter/MSTest.CoreAdapter/Execution/TestClassInfo.cs
* COnverting portable pdbs to full for Symbol archiving

* Fixing nuget package path

* Test fix

* Indent fix
* File version update

* Moving to 15.6

* PR comments

* More PR comments
…332)

* Throwing exception only if it is of type TestPlatformFormatException

* test

* Fail discovery if any exception thrown in IDiscoveryContext.GetTestCaseFilter
# Conflicts:
#	src/Adapter/MSTest.CoreAdapter/Discovery/AssemblyEnumeratorWrapper.cs
Copy link
Contributor

@smadala smadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My commit is there.

@mayankbansal018
Copy link
Contributor Author

@dotnet-bot test this please

@mayankbansal018 mayankbansal018 merged commit 22db939 into microsoft:1.2.1 Apr 3, 2018
singhsarab added a commit to singhsarab/testfx that referenced this pull request Apr 8, 2019
* Use direct conversions to/from JSON for TestCase and TestResult (without a local store for default properties)
* Related to microsoft#396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants