Code Maintenance with static analysers #699
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this as I have another PR #807 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDE0029 Null check can be simplified.
IDE0016 Null check can be simplified
IDE0017 Object initialization can be simplified.
IDE0019 Use pattern matching.
IDE0028 Collection initialization can be simplified.
IDE0054 Use compound assignment.
IDE1005 Delegate invocation can be simplified.
CA1507 Use nameof in place of string literal
CA1825: Avoid zero-length array allocations
CA1802 Field is declared as 'static readonly' but is initialized with a constant value. Mark this field as 'const' instead.
CA1813 Avoid unsealed attributes.
S1066 Merge this if statement with the enclosing one.
S2971 Drop 'Where' and move the condition into the 'Count'.
S2971 Drop 'Where' and move the condition into the 'FirstOrDefault'.
S2971 Drop this useless call to 'ToList' or replace it by 'AsEnumerable' if you are using LINQ to Entities.
S1125 Remove the unnecessary Boolean literal(s).
S1066 Merge this if statement with the enclosing one.
S1128 Remove this unnecessary 'using'.
SA1623 The property's documentation summary text must begin with: 'Gets'
SA1611 The documentation for parameter is missing.
SA1642 Constructor summary documentation must begin with standard text.