Add class/assembly cleanup/init messages to first/last test#1390
Merged
Evangelink merged 16 commits intomicrosoft:mainfrom Nov 24, 2022
Merged
Add class/assembly cleanup/init messages to first/last test#1390Evangelink merged 16 commits intomicrosoft:mainfrom
Evangelink merged 16 commits intomicrosoft:mainfrom
Conversation
Evangelink
reviewed
Nov 16, 2022
test/UnitTests/MSTestAdapter.UnitTests/Execution/TestExecutionManagerTests.cs
Show resolved
Hide resolved
Evangelink
reviewed
Nov 16, 2022
Evangelink
reviewed
Nov 23, 2022
Evangelink
reviewed
Nov 23, 2022
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Overall LGTM. Could you please review the test caseInheritClassWithCleanupInheritanceBehaviorNone_ParentTestMethod where the order of calls changed?
Evangelink
reviewed
Nov 23, 2022
Evangelink
requested changes
Nov 23, 2022
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
I think there is something fishy with the implementation (maybe how you find the test to attach cleanup results to) because it seems that the ClassCleanup.InheritanceBehaviorBeforeEachDerivedClass messages are not attached to the correct test.
Evangelink
reviewed
Nov 23, 2022
| if (!StringEx.IsNullOrEmpty(DebugTrace)) | ||
| { | ||
| string debugTraceMessagesInStdOut = string.Format(CultureInfo.InvariantCulture, "\n\n{0}\n{1}", Resource.DebugTraceBanner, DebugTrace); | ||
| string debugTraceMessagesInStdOut = string.Format(CultureInfo.CurrentCulture, "{2}{2}{0}{2}{1}", Resource.DebugTraceBanner, DebugTrace, Environment.NewLine); |
Member
There was a problem hiding this comment.
Use OS line return to avoid mixing line return kinds.
Evangelink
reviewed
Nov 23, 2022
Evangelink
reviewed
Nov 23, 2022
Evangelink
previously approved these changes
Nov 23, 2022
Evangelink
approved these changes
Nov 23, 2022
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #1340