Delete button Styling moved to CommonResource.xaml ; Issue #10454

[jelonmusk]

Issue #10454

There are a few places in the Settings UI where we have a "delete button":

Actions Page
Color Schemes Page
Profiles Page - Delete Profile
(PR Allow creating and editing unfocused appearances in the SUI #10317) Profiles Page - Delete Appearance: (just look up "Firebrick")
I moved these over to CommonResources.xaml.

I referred https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/Common_themeresources.xaml
as a reference for the code modification.
The styling code for "delete button" where moved to Common Resource.xaml file

[ghost]

All CLA requirements met.

[miniksa]

You cannot use the x:Key="SecondaryTextBlockStyle" key here because I already used this key above for a different purpose. You need to name this style differently here like calling it x:Key="DeleteButtonStyle" here and below in the other theme dictionaries.

[miniksa]

TargetType="TextBlock" is also not right.... I thought this was targeting Button?

[miniksa]

All of these likely need to turn into Setter items on Properties that are a part of Button with the color or brush binding to the relevant properties. It's sort of a backwards declaration to how it is done on an individual button override.

[jelonmusk]

It doesn't look like this builds either. Did you F5 it in Visual Studio to see if your shared style works?

Thanks for reviewing.
I have gone through all your replies and I'll make all the required changes.
I'll F5 it and see if it works after correcting the current code.

[miniksa]

The Button controls that are going to be using this common style instead of their individual overrides need those overrides removed and to contain the property Style="{ThemeResource WhateverYouNameTheXKeyLikeDeleteButtonStyleOrSomething}" instead so they refer to the common one.

terminal/src/cascadia/TerminalSettingsEditor/Launch.xaml

Lines 115 to 118 in 608a49e

	<TextBlock Grid.Row="1"
	Grid.Column="1"
	Style="{ThemeResource SecondaryTextBlockStyle}"
	Text="{x:Bind Author}" />

They may also need to have the CommonResources.xaml merged into their ResourceDictionary at the top before the XAML compiler will find the shared resource.

terminal/src/cascadia/TerminalSettingsEditor/Launch.xaml

Lines 17 to 19 in 608a49e

	<ResourceDictionary.MergedDictionaries>
	<ResourceDictionary Source="CommonResources.xaml" />
	</ResourceDictionary.MergedDictionaries>

[miniksa]

It doesn't look like this builds either. Did you F5 it in Visual Studio to see if your shared style works?

[ghost]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.