Move delete button theme resources into CommonResources.xaml

[carlos-zamora]

There's a few places in the Settings UI where we have a "delete button":

• Actions Page
• Color Schemes Page
• Profiles Page - Delete Profile
• (PR Allow creating and editing unfocused appearances in the SUI #10317) Profiles Page - Delete Appearance: (just look up "Firebrick")

We should move these over to CommonResources.xaml.

Examples of what this would look like:

• terminal/src/cascadia/TerminalSettingsEditor/CommonResources.xaml

  Lines 14 to 32 in b659321

  	<ResourceDictionary.ThemeDictionaries>
  	<ResourceDictionary x:Key="Light">
  	<Style x:Key="SecondaryTextBlockStyle"
  	TargetType="TextBlock">
  	<Setter Property="Foreground" Value="{ThemeResource SystemBaseMediumColor}" />
  	</Style>
  	</ResourceDictionary>
  	<ResourceDictionary x:Key="Dark">
  	<Style x:Key="SecondaryTextBlockStyle"
  	TargetType="TextBlock">
  	<Setter Property="Foreground" Value="{ThemeResource SystemBaseMediumColor}" />
  	</Style>
  	</ResourceDictionary>
  	<ResourceDictionary x:Key="HighContrast">
  	<Style x:Key="SecondaryTextBlockStyle"
  	TargetType="TextBlock" />
  	<!-- Do not mess with the foreground color for High Contrast. Let it ride as is. -->
  	</ResourceDictionary>
  	</ResourceDictionary.ThemeDictionaries>

• https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/Common_themeresources.xaml

If we have any other theme resources that we use in a few places, we should do the same. I'm also open to the idea of having a separate file named something like CommonThemeResources.xaml if we wanted to take that route.

[sourabh112]

Hi @miniksa @carlos-zamora, Can I work on this issue? As I'm quite new to open-source, I might need your guidance.

[zadjii-msft]

@sourabh112 Go right ahead!

[sourabh112]

Thanks @zadjii-msft , for the opportunity and sorry for late reply. I'm starting with making myself familiar with the code, so that my changes won't affect anything else.

[jelonmusk]

Hi
@miniksa @carlos-zamora, I would also like to work on this issue.
p.s. I'm a first-time contributor!

[jelonmusk]

https://github.com/jelonmusk/terminal/blob/main/src/cascadia/TerminalSettingsEditor/CommonResources.xaml

Here's the link to changes made in CommonResource.xaml file.
@miniksa Could you please review it?

[miniksa]

I will look at the PR.

[ghost]

🎉This issue was addressed in #12973, which has now been successfully released as Windows Terminal v1.13.1143.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉This issue was addressed in #12973, which has now been successfully released as Windows Terminal Preview v1.14.143.:tada:

Handy links:

• Release Notes
• Store Download