Dockerfile - add sm_103 support for cuda12.9 docker image #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
=======================================
Coverage 85.97% 85.97%
=======================================
Files 102 102
Lines 7579 7579
=======================================
Hits 6516 6516
Misses 1063 1063
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guoshzhao
reviewed
Sep 18, 2025
| RUN echo PATH="$PATH" > /etc/environment && \ | ||
| echo LD_LIBRARY_PATH="$LD_LIBRARY_PATH" >> /etc/environment && \ | ||
| echo SB_MICRO_PATH="$SB_MICRO_PATH" >> /etc/environment && \ | ||
| echo "source /opt/hpcx/hpcx-init.sh && hpcx_load" | tee -a /etc/bash.bashrc >> /etc/profile.d/10-hpcx.sh |
Contributor
There was a problem hiding this comment.
We don't need to call hpcx_load proactively?
Contributor
Author
There was a problem hiding this comment.
if no custom hpc-x installed we can just remove hpcx_load, but for cuda13.0 I see Dilip installed a custom hpc-x version so might need to wait later to see how to cope with both situations.
guoshzhao
reviewed
Sep 18, 2025
| ifeq ($(shell echo $(CUDA_VER)">=12.8" | bc -l), 1) | ||
| ifeq ($(shell echo $(CUDA_VER)">=12.9" | bc -l), 1) | ||
| # Get commit 87048bd from msscl to support updated nccl and sm_100 | ||
| $(eval ARCHS := 100 103) |
guoshzhao
added
enhancement
guoshzhao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sm_103 arch for executables with cuda arch dependency.
Removed duplicate installation of hpc-x and nccl in cuda12.9.dockerfile and cuda12.8.dockerfile