Revise Code - Fix wrong torch usage in communication wrapper for Distributed Inference Benchmark #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/0.8 #505 +/- ##
============================================
Coverage 87.31% 87.31%
============================================
Files 89 89
Lines 5944 5944
============================================
Hits 5190 5190
Misses 754 754
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yzygitzh
force-pushed
the
ziyyang/fix-dist-inf
branch
from
94e708f
to
78e8573
Compare
yzygitzh
changed the title
yzygitzh
force-pushed
the
ziyyang/fix-dist-inf
branch
from
78e8573
to
1619a08
Compare
abuccts
approved these changes
Apr 5, 2023
cp5555
changed the title
cp5555
approved these changes
Apr 5, 2023
cp5555
added
bug
yukirora
approved these changes
Apr 6, 2023
abuccts
pushed a commit
that referenced
this pull request
Apr 14, 2023
…nce Benchmark (#505) **Description** This commit fixes wrong `torch.empty_like` usage and missing dtype and device argument in communication wrappers.
abuccts
added a commit
that referenced
this pull request
Apr 14, 2023
**Description** Cherry-pick bug fixes from v0.8.0 to main. **Major Revisions** * Monitor - Fix the cgroup version checking logic (#502) * Benchmark - Fix matrix size overflow issue in cuBLASLt GEMM (#503) * Fix wrong torch usage in communication wrapper for Distributed Inference Benchmark (#505) * Analyzer: Fix bug in python3.8 due to pandas api change (#504) * Bug - Fix bug to get metric from cmd when error happens (#506) * Monitor - Collect realtime GPU power when benchmarking (#507) * Add num_workers argument in model benchmark (#511) * Remove unreachable condition when write host list (#512) * Update cuda11.8 image to cuda12.1 based on nvcr23.03 (#513) * Doc - Fix wrong unit of cpu-memory-bw-latency in doc (#515) * Docs - Upgrade version and release note (#508) Co-authored-by: guoshzhao <guzhao@microsoft.com> Co-authored-by: Ziyue Yang <ziyyang@microsoft.com> Co-authored-by: Yuting Jiang <yutingjiang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes wrong
torch.empty_likeusage and missing dtype and device argument in communication wrappers.