Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark - Fix matrix size overflow issue in cuBLASLt GEMM #503

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented Apr 4, 2023

Fix matrix size overflow issue when cast from int to size_t implicitly.

Fix matrix size overflow issue when cast from int to size_t implicitly.
@abuccts abuccts added the micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks label Apr 4, 2023
@abuccts abuccts requested a review from a team as a code owner April 4, 2023 06:49
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #503 (f149ebe) into release/0.8 (26373ed) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/0.8     #503   +/-   ##
============================================
  Coverage        87.31%   87.31%           
============================================
  Files               89       89           
  Lines             5944     5944           
============================================
  Hits              5190     5190           
  Misses             754      754           
Flag Coverage Δ
cpu-python3.6-unit-test 73.58% <ø> (ø)
cpu-python3.7-unit-test 73.58% <ø> (ø)
cpu-python3.8-unit-test 74.05% <ø> (ø)
cuda-unit-test 87.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cp5555 cp5555 changed the title Benchmark - Fix matrix size overflow issue Benchmark - Fix matrix size overflow issue in CuBLASLT GEMM Apr 4, 2023
@cp5555 cp5555 mentioned this pull request Apr 4, 2023
23 tasks
Update error message.
@abuccts abuccts changed the title Benchmark - Fix matrix size overflow issue in CuBLASLT GEMM Benchmark - Fix matrix size overflow issue in cuBLASLt GEMM Apr 4, 2023
@abuccts abuccts enabled auto-merge (squash) April 4, 2023 08:23
@cp5555 cp5555 added the bug Something isn't working label Apr 5, 2023
Workaround unit test.
@abuccts abuccts disabled auto-merge April 6, 2023 04:44
@abuccts abuccts merged commit 9d250cd into release/0.8 Apr 6, 2023
@abuccts abuccts deleted the xiongyf/cublaslt-fix-size branch April 6, 2023 05:16
abuccts added a commit that referenced this pull request Apr 14, 2023
Fix matrix size overflow issue when cast from int to size_t implicitly.
abuccts added a commit that referenced this pull request Apr 14, 2023
**Description**

Cherry-pick bug fixes from v0.8.0 to main.

**Major Revisions**

* Monitor - Fix the cgroup version checking logic (#502)
* Benchmark - Fix matrix size overflow issue in cuBLASLt GEMM (#503)
* Fix wrong torch usage in communication wrapper for Distributed
Inference Benchmark (#505)
* Analyzer: Fix bug in python3.8 due to pandas api change (#504)
* Bug - Fix bug to get metric from cmd when error happens (#506)
* Monitor - Collect realtime GPU power when benchmarking (#507)
* Add num_workers argument in model benchmark (#511)
* Remove unreachable condition when write host list (#512)
* Update cuda11.8 image to cuda12.1 based on nvcr23.03 (#513)
* Doc - Fix wrong unit of cpu-memory-bw-latency in doc (#515)
* Docs - Upgrade version and release note (#508)

Co-authored-by: guoshzhao <guzhao@microsoft.com>
Co-authored-by: Ziyue Yang <ziyyang@microsoft.com>
Co-authored-by: Yuting Jiang <yutingjiang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants