Skip to content

Add callback for Table CellResizer #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinguyen12 merged 4 commits into from
Oct 7, 2025
Merged

Add callback for Table CellResizer #3173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
665f4c5
Add callback for cell resizer
Oct 6, 2025
8e58ddf
Merge branch 'master' into u/nguyenvi/add-callback-cellresizer
vinguyen12 Oct 6, 2025
5a0784a
add empty space
Oct 7, 2025
7316ee1
Merge branch 'u/nguyenvi/add-callback-cellresizer' of https://github.…
Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/roosterjs-content-model-plugins/lib/tableEdit/editors/TableEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,8 @@ export class TableEditor {
true /*isHorizontal*/,
this.onStartCellResize,
this.onFinishEditing,
this.anchorContainer
this.anchorContainer,
this.onTableEditorCreated
);
this.verticalResizer = createCellResizer(
this.editor,
Expand All @@ -266,7 +267,8 @@ export class TableEditor {
false /*isHorizontal*/,
this.onStartCellResize,
this.onFinishEditing,
this.anchorContainer
this.anchorContainer,
this.onTableEditorCreated
);
}
}
Expand Down
32 changes: 29 additions & 3 deletions packages/roosterjs-content-model-plugins/lib/tableEdit/editors/features/CellResizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
} from 'roosterjs-content-model-dom';
import type { DragAndDropHandler } from '../../../pluginUtils/DragAndDrop/DragAndDropHandler';
import type { IEditor, ReadonlyContentModelTable } from 'roosterjs-content-model-types';
import type { OnTableEditorCreatedCallback } from '../../OnTableEditorCreatedCallback';

const CELL_RESIZER_WIDTH = 4;
/**
Expand All @@ -34,7 +35,8 @@ export function createCellResizer(
isHorizontal: boolean,
onStart: () => void,
onEnd: () => false,
anchorContainer?: HTMLElement
anchorContainer?: HTMLElement,
onTableEditorCreated?: OnTableEditorCreatedCallback
): TableEditFeature | null {
const document = td.ownerDocument;
const createElementData = {
Expand Down Expand Up @@ -66,18 +68,42 @@ export function createCellResizer(
onDragEnd: onEnd,
};

const featureHandler = new DragAndDropHelper<CellResizerContext, CellResizerInitValue>(
const featureHandler = new CellResizer(
div,
context,
setPosition,
handler,
zoomScale,
editor.getEnvironment().isMobileOrTablet
editor.getEnvironment().isMobileOrTablet,
onTableEditorCreated
);

return { node: td, div, featureHandler };
}

class CellResizer extends DragAndDropHelper<CellResizerContext, CellResizerInitValue> {
private disposer: undefined | (() => void);

constructor(
trigger: HTMLElement,
context: CellResizerContext,
onSubmit: (context: CellResizerContext, trigger: HTMLElement) => void,
handler: DragAndDropHandler<CellResizerContext, CellResizerInitValue>,
zoomScale: number,
forceMobile?: boolean,
onTableEditorCreated?: OnTableEditorCreatedCallback
) {
super(trigger, context, onSubmit, handler, zoomScale, forceMobile);
this.disposer = onTableEditorCreated?.('CellResizer', trigger);
}

dispose(): void {
this.disposer?.();
this.disposer = undefined;
super.dispose();
}
}

/**
* @internal
* Exported for testing
Expand Down
Loading