Skip to content

Conversation

@vinguyen12
Copy link
Contributor

Add callback for Table CellResizer similar to other TableEditFeature.

With this, client will have more control over how they can define the resizer component and action.

@JiuqingSong
Copy link
Collaborator

question, what do we want to do with this callback?

@vinguyen12
Copy link
Contributor Author

question, what do we want to do with this callback?

This callback gives us access to the CellResizer handler component, so we can use it for applying the wanted z-index there (similar to what we're doing for other components of TableResizer and TableInserter)

@vinguyen12 vinguyen12 requested a review from Copilot October 7, 2025 18:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds callback functionality to the Table CellResizer feature to provide clients with more control over resizer component definition and actions, bringing consistency with other TableEditFeature implementations.

  • Added OnTableEditorCreatedCallback parameter to createCellResizer function
  • Created a new CellResizer class that extends DragAndDropHelper to handle the callback lifecycle
  • Updated TableEditor to pass the callback to both horizontal and vertical cell resizers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
CellResizer.ts Added callback parameter and created CellResizer class with proper disposal handling
TableEditor.ts Updated calls to createCellResizer to include the onTableEditorCreated callback

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vinguyen12 vinguyen12 merged commit cb4e7c9 into master Oct 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants